From nobody Mon Jul 28 13:31:47 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brKBs1vqxz635Km; Mon, 28 Jul 2025 13:31:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brKBq354Kz3vk0; Mon, 28 Jul 2025 13:31:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PTQymAJJdBI7PyNBp2RyCEhTDl4NMdBeCr6fiC3tXt4=; b=BsgA1dENkfh1ZT4O2PnZNp8+riNBgTBRQk4yirqKJOeCbXWulCIzi3EJH+nJB8iEucOxPw LKK61pgqkfgW/qn89p7u/OofywhFhSpzS2AqSLNIBrN4RqPAaUuTH10oJvGp9KnZ7bUK2D /QEGWkPXfREe7aM0uLyqYgqDxwkli1zOky5ENyHRWIe2HFWw6CXsHSy4Mwyj8vNZRu+f8g dQAr4p3pYjca6TqqffnfRLEunOXyVljL2giXnu3py0iPspOS7xjQE2+SrbaC9Ql0MXiBg6 /g9IQTRdVqMUlID47C4BYg5u0cCrFgK0p1bqn9gikhj6/LkFnS31X7W/YPLD4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PTQymAJJdBI7PyNBp2RyCEhTDl4NMdBeCr6fiC3tXt4=; b=pmF4RtsjM15xP1Aqfjhqs64yrEUMT7Z5XILHFNdEkHqUw1uIOUPmeSNA8af8q4qV/Lhmcg j2luPbXg3qeC/CYkc6l47v/UJWXEK2avMLFG3/BkPkaJ04dnIixRtJjiAV0Cb3cbOX4JoI FTf7vqbxN/gduyG7QvrEjMrpQzjlOIJguZMmEvPX8+wrsG80Onh7so5heYFuobD3kSAwaY 1Uyn+iHCtinSoo23pcCFm3EXWbumPPXq6Iq3dIC5eVApp6LlBrfytf/faNkr1QiI6jeMhI 55j1vWDbXVC2p/OGsbwalD6IRhSbBb0gWQLKvNX0kQgsQuZftDZzwlLWKuoRYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753709507; a=rsa-sha256; cv=none; b=rJXW23KtQ5hbk5jnPX3rVX81jGwS+BW5iWAnCGJ1cg0AwFnYqK6yugga+DSorGbx5j/Lgd 6LvOcNZF+p9zYSzt/7doRggZx8eEDBzuuxayY7cEug3Ktedy+cutSUGv/LlvLp+vcTd1Ds mr+DW3D+AJlDDqGtge1xBgHxSytocoJfuNGYPxL6s/gR9SLUT8AMEXGOY6Ll74lSg9QgDO G4lyKXK/na3JL32s9Lbg5gMrWCkFfQwfz4d8mq+G3tAtsZnFhMgA9PgQANOCgeES3p6Rqt wRROi3Vl69wAscnVeXX75fJuojXueuCo8Nz3pKTLoHoJVfX17mDwcUQwE+hwWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4brKBq2TRzzngD; Mon, 28 Jul 2025 13:31:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56SDVlcS082402; Mon, 28 Jul 2025 13:31:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56SDVlXn082399; Mon, 28 Jul 2025 13:31:47 GMT (envelope-from git) Date: Mon, 28 Jul 2025 13:31:47 GMT Message-Id: <202507281331.56SDVlXn082399@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: d738ed04dbff - stable/14 - LinuxKPI: alloc_pages(): Don't reclaim on __GFP_NORETRY List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d738ed04dbff78243617ac341486b86486e9c8be Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=d738ed04dbff78243617ac341486b86486e9c8be commit d738ed04dbff78243617ac341486b86486e9c8be Author: Olivier Certner AuthorDate: 2025-07-07 12:27:48 +0000 Commit: Olivier Certner CommitDate: 2025-07-28 13:28:49 +0000 LinuxKPI: alloc_pages(): Don't reclaim on __GFP_NORETRY Pass VM_ALLOC_NORECLAIM to vm_page_alloc_noobj_contig() so that it avoids reclaiming (currently, calling vm_reserv_reclaim_contig()). According to Linux's documentation, __GFP_NORETRY should not cause any "disruptive reclaim". alloc_pages() is called a lot from the amdgpu DRM driver via ttm_pool_alloc(), which tries to allocate pages of the highest order first and fallback to lower order pages (as allocating contiguous physical pages is in fact not a requirement). This process relies on failing fast, as requested by __GFP_NORETRY. See also related commit 718d1928f874 ("LinuxKPI: make linux_alloc_pages() honor __GFP_NORETRY"). Reviewed by: jeffpc_josefsipek.net, bz MFC after: 10 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D51246 (cherry picked from commit 4ca9190251bbd00c928a3cba54712c3ec25e9e26) Forgotten on commit to main/-CURRENT: PR: 277476 --- sys/compat/linuxkpi/common/src/linux_page.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/compat/linuxkpi/common/src/linux_page.c b/sys/compat/linuxkpi/common/src/linux_page.c index 99b63e8d5680..bb5a1411eeec 100644 --- a/sys/compat/linuxkpi/common/src/linux_page.c +++ b/sys/compat/linuxkpi/common/src/linux_page.c @@ -107,6 +107,7 @@ linux_alloc_pages(gfp_t flags, unsigned int order) if ((flags & M_ZERO) != 0) req |= VM_ALLOC_ZERO; + if (order == 0 && (flags & GFP_DMA32) == 0) { page = vm_page_alloc_noobj(req); if (page == NULL) @@ -114,6 +115,10 @@ linux_alloc_pages(gfp_t flags, unsigned int order) } else { vm_paddr_t pmax = (flags & GFP_DMA32) ? BUS_SPACE_MAXADDR_32BIT : BUS_SPACE_MAXADDR; + + if ((flags & __GFP_NORETRY) != 0) + req |= VM_ALLOC_NORECLAIM; + retry: page = vm_page_alloc_noobj_contig(req, npages, 0, pmax, PAGE_SIZE, 0, VM_MEMATTR_DEFAULT);