Date: Sat, 22 Sep 2012 08:31:21 -0400 From: Mike Tancsa <mike@sentex.net> To: Jim Harris <jimharris@freebsd.org> Cc: FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>, delphij@freebsd.org Subject: Re: tws bug ? (LSI SAS 9750) Message-ID: <505DAF99.1060201@sentex.net> In-Reply-To: <CAJP=Hc8Y%2B0seMb88VLOMf17vQ8rVJ3fiyZTnU_YPOGUe58fXaQ@mail.gmail.com> References: <505CC8EC.4030608@sentex.net> <CAJP=Hc9=Rk5EvbmSe=XJJq_r0WO7DW3oUvxxK3ALAbJRUSgX7g@mail.gmail.com> <505CE601.4070106@sentex.net> <CAJP=Hc-iAixiCUGaR9NPKBxEh-gVv7mGDkQDYg3dpUsqr8iGjA@mail.gmail.com> <505D0846.8050108@sentex.net> <CAJP=Hc8Y%2B0seMb88VLOMf17vQ8rVJ3fiyZTnU_YPOGUe58fXaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/21/2012 11:17 PM, Jim Harris wrote: >> What about a change similar to what Alexander Motin did in >> >> http://lists.freebsd.org/pipermail/svn-src-head/2012-June/038196.html > > Ah, yes. I was thinking you had CAM_DEBUG enabled which is why you > were seeing this spew - but that's not the case. This indeed should > be fixed and not just ignored. > > Seeing the attributions on Alexander's commit, you certainly seem to > have a monopoly on controllers that exhibit this problem on FreeBSD. > :) > > I believe the CAM_LUN_INVALID here should be fixed as well, similar to > the twa commit. If you send me a revised patch I will commit it. Thanks, yes seems to be déjà vu all over again with this manufacturer :) I think this is correct ? 0(ich10)# diff -u tws_cam.c.orig tws_cam.c --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400 +++ tws_cam.c 2012-09-22 08:21:36.000000000 -0400 @@ -529,10 +529,10 @@ if ( ccb->ccb_h.target_lun ) { TWS_TRACE_DEBUG(sc, "invalid lun error",0,0); - ccb->ccb_h.status |= CAM_LUN_INVALID; + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; } else { TWS_TRACE_DEBUG(sc, "invalid target error",0,0); - ccb->ccb_h.status |= CAM_TID_INVALID; + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; } } else { 1(ich10)# ---Mike > > Thanks, > > -Jim > > >> >> 0(ich10)# diff -u tws_cam.c.orig tws_cam.c >> --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400 >> +++ tws_cam.c 2012-09-21 20:11:11.000000000 -0400 >> @@ -532,7 +532,7 @@ >> ccb->ccb_h.status |= CAM_LUN_INVALID; >> } else { >> TWS_TRACE_DEBUG(sc, "invalid target error",0,0); >> - ccb->ccb_h.status |= CAM_TID_INVALID; >> + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; >> } >> >> } else { >> 1(ich10)# >> >> ---Mike >> >> >> -- >> ------------------- >> Mike Tancsa, tel +1 519 651 3400 >> Sentex Communications, mike@sentex.net >> Providing Internet services since 1994 www.sentex.net >> Cambridge, Ontario Canada http://www.tancsa.com/ > > -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?505DAF99.1060201>