From owner-freebsd-stable@FreeBSD.ORG Sat Sep 22 12:31:26 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 381B61065686; Sat, 22 Sep 2012 12:31:26 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost1.sentex.ca (smarthost1-6.sentex.ca [IPv6:2607:f3e0:0:1::12]) by mx1.freebsd.org (Postfix) with ESMTP id E97778FC0C; Sat, 22 Sep 2012 12:31:25 +0000 (UTC) Received: from [192.168.43.26] (pyroxene.sentex.ca [199.212.134.18]) by smarthost1.sentex.ca (8.14.5/8.14.5) with ESMTP id q8MCVKeq009660; Sat, 22 Sep 2012 08:31:20 -0400 (EDT) (envelope-from mike@sentex.net) Message-ID: <505DAF99.1060201@sentex.net> Date: Sat, 22 Sep 2012 08:31:21 -0400 From: Mike Tancsa Organization: Sentex Communications User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jim Harris References: <505CC8EC.4030608@sentex.net> <505CE601.4070106@sentex.net> <505D0846.8050108@sentex.net> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.72 on 64.7.153.18 Cc: FreeBSD-STABLE Mailing List , delphij@freebsd.org Subject: Re: tws bug ? (LSI SAS 9750) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Sep 2012 12:31:26 -0000 On 9/21/2012 11:17 PM, Jim Harris wrote: >> What about a change similar to what Alexander Motin did in >> >> http://lists.freebsd.org/pipermail/svn-src-head/2012-June/038196.html > > Ah, yes. I was thinking you had CAM_DEBUG enabled which is why you > were seeing this spew - but that's not the case. This indeed should > be fixed and not just ignored. > > Seeing the attributions on Alexander's commit, you certainly seem to > have a monopoly on controllers that exhibit this problem on FreeBSD. > :) > > I believe the CAM_LUN_INVALID here should be fixed as well, similar to > the twa commit. If you send me a revised patch I will commit it. Thanks, yes seems to be déjà vu all over again with this manufacturer :) I think this is correct ? 0(ich10)# diff -u tws_cam.c.orig tws_cam.c --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400 +++ tws_cam.c 2012-09-22 08:21:36.000000000 -0400 @@ -529,10 +529,10 @@ if ( ccb->ccb_h.target_lun ) { TWS_TRACE_DEBUG(sc, "invalid lun error",0,0); - ccb->ccb_h.status |= CAM_LUN_INVALID; + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; } else { TWS_TRACE_DEBUG(sc, "invalid target error",0,0); - ccb->ccb_h.status |= CAM_TID_INVALID; + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; } } else { 1(ich10)# ---Mike > > Thanks, > > -Jim > > >> >> 0(ich10)# diff -u tws_cam.c.orig tws_cam.c >> --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400 >> +++ tws_cam.c 2012-09-21 20:11:11.000000000 -0400 >> @@ -532,7 +532,7 @@ >> ccb->ccb_h.status |= CAM_LUN_INVALID; >> } else { >> TWS_TRACE_DEBUG(sc, "invalid target error",0,0); >> - ccb->ccb_h.status |= CAM_TID_INVALID; >> + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; >> } >> >> } else { >> 1(ich10)# >> >> ---Mike >> >> >> -- >> ------------------- >> Mike Tancsa, tel +1 519 651 3400 >> Sentex Communications, mike@sentex.net >> Providing Internet services since 1994 www.sentex.net >> Cambridge, Ontario Canada http://www.tancsa.com/ > > -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/