Date: Sun, 28 Oct 2018 08:31:58 -0500 From: Jason Bacon <bacon4000@gmail.com> To: Jan Beich <jbeich@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483245 - head/biology/stacks Message-ID: <cc0e5427-eef4-bce0-5285-647335ef2f18@gmail.com> In-Reply-To: <5zxm-1d6y-wny@FreeBSD.org> References: <201810280858.w9S8w0sk015320@repo.freebsd.org> <5zxm-1d6y-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks reasonable to me and works on amd64. In cases like this I would add a comment # Also requires openmp USES= compiler:gcc-c++11-lib gmake python shebangfix to document why we're using gcc. On 10/28/18 7:13 AM, Jan Beich wrote: > Mark Linimon <linimon@FreeBSD.org> writes: > >> Author: linimon >> Date: Sun Oct 28 08:58:00 2018 >> New Revision: 483245 >> URL: https://svnweb.freebsd.org/changeset/ports/483245 >> >> Log: >> Fix build with tier-2 arches. >> >> PR: 231448 >> Submitted by: Piotr Kubaj >> Approved by: maintainer >> >> Modified: >> head/biology/stacks/Makefile >> >> Modified: head/biology/stacks/Makefile >> ============================================================================== >> --- head/biology/stacks/Makefile Sun Oct 28 08:56:24 2018 (r483244) >> +++ head/biology/stacks/Makefile Sun Oct 28 08:58:00 2018 (r483245) >> @@ -18,4 +18,10 @@ GNU_CONFIGURE= yes >> >> LDFLAGS+= -lpthread >> >> -.include <bsd.port.mk> >> +.include <bsd.port.pre.mk> >> + >> +.if ${ARCH} != amd64 && ${ARCH} != i386 >> +USE_GCC= yes >> +.endif >> + >> +.include <bsd.port.post.mk> > Why not USES=compiler:gcc-c++11-lib ? > -- Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cc0e5427-eef4-bce0-5285-647335ef2f18>