From owner-svn-src-all@FreeBSD.ORG Tue May 12 18:41:51 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A11AA10656A3 for ; Tue, 12 May 2009 18:41:51 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 518748FC08 for ; Tue, 12 May 2009 18:41:51 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id 59E578FC53 for ; Tue, 12 May 2009 22:41:50 +0400 (MSD) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id 7CC768FC4E; Tue, 12 May 2009 22:41:47 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 5F1B439828; Tue, 12 May 2009 22:42:13 +0400 (MSD) Date: Tue, 12 May 2009 22:42:13 +0400 From: Stanislav Sedov To: John Baldwin Message-Id: <20090512224213.f80f2fd3.stas@FreeBSD.org> In-Reply-To: <200905121217.06048.jhb@freebsd.org> References: <200905121607.n4CG78wX026915@svn.freebsd.org> <200905121217.06048.jhb@freebsd.org> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Tue May 12 22:41:50 2009 X-DSPAM-Confidence: 0.9899 X-DSPAM-Improbability: 1 in 9809 chance of being spam X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 4a09c2ee994291210395111 Cc: Stanislav Sedov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192018 - head/sys/arm/at91 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2009 18:41:52 -0000 On Tue, 12 May 2009 12:17:05 -0400 John Baldwin mentioned: > On Tuesday 12 May 2009 12:07:08 pm Stanislav Sedov wrote: > > Author: stas > > Date: Tue May 12 16:07:08 2009 > > New Revision: 192018 > > URL: http://svn.freebsd.org/changeset/base/192018 > > > > Log: > > - Implement detach path. > > - Release memory and DMA resources on stop. > > - Unload the associated DMA maps after transmit is complete. > > Most NIC drivers that I am familiar with do not destroy DMA resources (tags > and maps) during stop() and then create them during if_init(). Instead, they > create those during attach() and detach(). They do tend to populate the RX > ring with buffers during if_init() and free all of the mbus during stop() > though. > Well, probably my commit message was slightly wrong. I do not destroy DMA maps and tags in the stop routine, instead I free all allocated mbufs and unload DMA maps associated with them. -- Stanislav Sedov ST4096-RIPE !DSPAM:4a09c2ee994291210395111!