Date: Mon, 31 Aug 2020 13:06:23 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 249024] cmake.mk: Add USES=cmake:testing to facilitate defining test targets for cmake-based ports Message-ID: <bug-249024-7788-bdEmAbjI2J@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-249024-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-249024-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D249024 Adriaan de Groot <adridg@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adridg@freebsd.org --- Comment #5 from Adriaan de Groot <adridg@freebsd.org> --- This looks mostly sensible to me: - it only adds testing and BUILD_TESTING via the framework when a port explicitly mentions `USES=3Dcmake:testing`. - it looks awfully over-engineered with possibilities for ON, OFF, different targets, ... but as long as that complexity is hidden and documented in the framework and the basic interface (`USES=3Dcmake:testing`) is simple, I don= 't object to that. I wonder what ports will be using it. - potentially re-building the entire port with new flags for do-test seems a bit over-the-top, perhaps the default setup could push `BUILD_TESTING` to t= he normal `CMAKE_ARGS` (like an unconditional `include(CTest)` would). So, overall: LGTM. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-249024-7788-bdEmAbjI2J>