From owner-freebsd-security@FreeBSD.ORG Sun Jan 30 21:25:06 2011 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C220B106564A for ; Sun, 30 Jan 2011 21:25:06 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from gromit.grondar.org (grandfather.grondar.org [IPv6:2a01:348:0:15:5d59:5c20:0:2]) by mx1.freebsd.org (Postfix) with ESMTP id 5AC0F8FC08 for ; Sun, 30 Jan 2011 21:25:06 +0000 (UTC) Received: from uucp by gromit.grondar.org with local-rmail (Exim 4.73 (FreeBSD)) (envelope-from ) id 1Pjeld-000AOC-Dh for freebsd-security@freebsd.org; Sun, 30 Jan 2011 21:25:05 +0000 Received: from localhost ([127.0.0.1] helo=groundzero.grondar.org) by groundzero.grondar.org with esmtp (Exim 4.74 (FreeBSD)) (envelope-from ) id 1Pjeie-000Efv-Mi; Sun, 30 Jan 2011 21:22:00 +0000 To: David Magda In-reply-to: <6C7C5856-4551-4BCA-A15B-30E422D028CC@ee.ryerson.ca> References: <6C7C5856-4551-4BCA-A15B-30E422D028CC@ee.ryerson.ca> From: Mark Murray Date: Sun, 30 Jan 2011 21:22:00 +0000 Message-Id: Cc: freebsd-security@FreeBSD.org Subject: Re: Add SHA-256/512 hash algorithm to crypt(3) (kern/124164) X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2011 21:25:06 -0000 David Magda writes: > On Jan 30, 2011, at 04:55, Mark Murray wrote: > > > David Magda writes: > >> Is there any chance that kern/124164 [1] could be looked at? The > >> included patch has been updated by KIMURA Yasuhiro for 8.1R, and so > >> hopefully would be okay for 8.3R (and maybe even -CURRENT). > > > > I've taken this. It will go in CURRENT first. 8.3 seems like a > > reasonable later merge. > > Awesome! Thanks. No problemo. Just as a first cut, I'm going to "FreeBSD-ify" the code, to get it up to our style(9) standards. Apart from stylistic issues, we already have SHA256 and SHA512 in our libraries, and they don't have alignment issues, So I'll use them instead. You've donated to code to "public domain"; any objection if I make this a BSD 2-clause license with FreeBSD as the copyright holder? Many places have weird problems with the concept of "public domain", and 2-clause BSD is pretty darned close. M -- Mark R V Murray Cert APS(Open) Dip Phys(Open) BSc Open(Open) BSc(Hons)(Open) Pi: 132511160