From owner-svn-src-head@freebsd.org  Mon Feb 19 22:13:53 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA26CF03756;
 Mon, 19 Feb 2018 22:13:52 +0000 (UTC)
 (envelope-from byond.lenox@gmail.com)
Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com
 [209.85.215.48])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5A59E6ED56;
 Mon, 19 Feb 2018 22:13:52 +0000 (UTC)
 (envelope-from byond.lenox@gmail.com)
Received: by mail-lf0-f48.google.com with SMTP id r80so1477769lfe.13;
 Mon, 19 Feb 2018 14:13:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=XJ4JwUC8hCCIjFMQAXovJAvQj/9NijwpWip1/lmYrz0=;
 b=UDDCJa8XAvHQ2G57UuLfiTFt8QLjqe6ApAqzI/aszaDMOhK3LyF2oYIkE03sW2Q7VE
 PsgL8u3WHg6OyqicYgRPYezxmrwf6FVQKHnPEJs3ZixNdSFCBJK8HugRrBp2+JFZ/nY9
 pgcMEDtM2Qf6J5HDTxhPB5lBvTf5RZwMSUlXjVy0rbE4u9jTzuScP+nDN++EZ5zQp3hb
 WOCXpvb3Ii04Wqx/RhpPPVX6oXP2Bg6/ILTQQzYuouDXnFY9u01nt8ASWtO2WEUudMra
 JaMzFW2jBYbEOEZafPAsUUMEj450+D5ezGKvSrGQDBFzG8/nhgpG2QGkitNNe0oOWLpl
 yD0Q==
X-Gm-Message-State: APf1xPBbIYmCbXwAuOE1xWqh3Q/N9/O6qMb5sOy0E1Yor/ptPStS2yCT
 LTHLTnOXWFLQunu6o1Bu4nGFHkbL
X-Google-Smtp-Source: AH8x225hFrLD1yF1ZJRJ7tKdZ9PkHKbFUsVK41yVxZccyiQmREkLDi/33aJqM0I0ztDI51UlJ+Ec3A==
X-Received: by 10.25.239.10 with SMTP id n10mr10252872lfh.8.1519078424100;
 Mon, 19 Feb 2018 14:13:44 -0800 (PST)
Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com.
 [209.85.215.43])
 by smtp.gmail.com with ESMTPSA id g24sm1324298lje.97.2018.02.19.14.13.43
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 19 Feb 2018 14:13:44 -0800 (PST)
Received: by mail-lf0-f43.google.com with SMTP id y19so1506442lfd.4;
 Mon, 19 Feb 2018 14:13:43 -0800 (PST)
X-Received: by 10.46.88.84 with SMTP id x20mr11088723ljd.44.1519078423776;
 Mon, 19 Feb 2018 14:13:43 -0800 (PST)
MIME-Version: 1.0
Received: by 10.46.106.8 with HTTP; Mon, 19 Feb 2018 14:13:23 -0800 (PST)
In-Reply-To: <20180219220001.GA12274@neva>
References: <201802191636.w1JGaTci003687@repo.freebsd.org>
 <20180219220001.GA12274@neva>
From: Kyle Evans <kevans@freebsd.org>
Date: Mon, 19 Feb 2018 16:13:23 -0600
X-Gmail-Original-Message-ID: <CACNAnaF0YTdOTPUJEiec8ryE=T92sAdZfPk9bEFZmF9BMY2yYg@mail.gmail.com>
Message-ID: <CACNAnaF0YTdOTPUJEiec8ryE=T92sAdZfPk9bEFZmF9BMY2yYg@mail.gmail.com>
Subject: Re: svn commit: r329587 - head/stand/lua
To: Alexander Nasonov <alnsn@yandex.ru>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Feb 2018 22:13:53 -0000

On Mon, Feb 19, 2018 at 4:00 PM, Alexander Nasonov <alnsn@yandex.ru> wrote:
> Kyle Evans wrote:
>> +             -- Swap the first two menu items on single user boot
>> +             if (core.isSingleUserBoot()) then
>> +                     local multiuser = menu_entries[1];
>> +                     local singleuser = menu_entries[2];
>> +
>> +                     menu_entries[2] = multiuser;
>> +                     menu_entries[1] = singleuser;
>> +             end
>
>                 -- Swap the first two menu items on single user boot
>                 if core.isSingleUserBoot() then
>                         menu_entries[1], menu_entries[2] =
>                             menu_entries[2], menu_entries[1]
>                 end
>

Noted. I ended up expanding this section a little bit later (see:
r329593) and I'm not sure how I feel about the look of this one:


                        -- Shallow copy the table
                        menu_entries = core.shallowCopyTable(menu_entries);

                        menu_entries[1], menu_entries[2] = menu_entries[2],
                            menu_entries[1];

                        menu_entries[1].name, menu_entries[2].name =
                            menu_entries[1].alternate_name,
                            menu_entries[2].alternate_name;

I'll need to sit on that one for a little bit. =)