From owner-cvs-all@FreeBSD.ORG  Wed Nov 17 01:36:51 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 595621065670; Wed, 17 Nov 2010 01:36:51 +0000 (UTC)
Date: Wed, 17 Nov 2010 01:36:51 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Steven Kreuzer <skreuzer@FreeBSD.org>
Message-ID: <20101117013651.GA75878@FreeBSD.org>
References: <201011162039.oAGKdmBn091947@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201011162039.oAGKdmBn091947@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel Makefile ports/devel/gdb Makefile
	distinfo pkg-descr pkg-plist ports/devel/gdb/files
	fbsd-threads.c patch-gdb-Makefile.in
	patch-gdb-amd64fbsd-nat.c patch-gdb-amd64fbsd-tdep.c
	patch-gdb-configure.tgt patch-gdb-i386bsd-nat.c
	patch-gdb-i386bsd-nat.h ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Nov 2010 01:36:51 -0000

On Tue, Nov 16, 2010 at 08:39:48PM +0000, Steven Kreuzer wrote:
>   Log:
>   GDB is a source-level debugger for Ada, C, C++, Objective-C, Pascal and
>   many other languages.  GDB can target (i.e., debug programs running on)
>   more than a dozen different processor architectures, and GDB itself can
>   run on most popular GNU/Linux, Unix and Microsoft Windows variants.

Nice!  Couple of minor nits:

- Spaces should be tab after MASTER_SITES=
- MASTER_SITE_SUBDIR=gdb/:gdb and :gdb suffix stuff in general seems to
  be copied from gdb6* ports maintained by mi@.  Looking at those, it is
  clear what suffix is for (hint: :gdbtk), but for this port I see no
  point in it; it just obfuscates the logic here
- VER= and MAN1= values are not properly indented

>   1.1       +6 -0      ports/devel/gdb/pkg-descr (new)

Tab after WWW: should be space.

>   1.1       +2 -0      ports/devel/gdb/pkg-plist (new)

Ugh.  Two-line plist file?  Why not use PLIST_FILES instead?

./danfe