Date: Sun, 27 Mar 2022 22:28:07 +0800 From: Archimedes Gaviola <archimedes.gaviola@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: freebsd-arm@freebsd.org Subject: Re: Raspberry Pi 3B USB Printing Issue Message-ID: <CAJFbk7G8gUjBPLHJEGvU4SULCQP5eGhNATOW0-paRgz8pqcqQg@mail.gmail.com> In-Reply-To: <d0cdee81-bb27-cec3-8fa1-74a381e9f3b3@selasky.org> References: <CAJFbk7EzSfPNbaGxiweKrivwNrKXCPVzA1b7_=0_bTvbs8oBow@mail.gmail.com> <7c67118e-f6ec-c87d-9a81-3ee6a5952f49@selasky.org> <CAJFbk7GYbLAFTJY077Nzh3CTBJM6bk8swr4AkgGMaukCxrfcHQ@mail.gmail.com> <60f98b10-dcdc-cdf4-3d7a-fe9fd4dff223@selasky.org> <CAJFbk7EAjrQG5Kj_upVKW72opOS%2B8d63VrMnQdLxcJjUcfsd=g@mail.gmail.com> <8226461b-5740-9c19-0575-2740bd952e16@selasky.org> <CAJFbk7FMa_8EXM70HdhgdLmkpjpRD54fRrO=uctHV4uQ2_nNhA@mail.gmail.com> <5fcece51-b014-330e-b701-fd75fa1ac204@selasky.org> <CAJFbk7Gx1i5r-KunNP41re7A_6m%2BYPO6K3Ru-J=0xqidNQsj7A@mail.gmail.com> <a5d5f948-fdc8-037c-dda6-5291e7440e28@selasky.org> <CAJFbk7GAz44pwFUdYQJKMfDA1EXZ%2BJSqYCxeRyuCaYk-u%2BiPNw@mail.gmail.com> <d0cdee81-bb27-cec3-8fa1-74a381e9f3b3@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000055ff3005db3402bb
Content-Type: text/plain; charset="UTF-8"
On Sun, Mar 27, 2022 at 5:05 PM Hans Petter Selasky <hps@selasky.org> wrote:
> On 3/27/22 07:55, Archimedes Gaviola wrote:
> > On Sat, Mar 12, 2022 at 4:41 PM Hans Petter Selasky <hps@selasky.org>
> wrote:
> >
> >> On 3/12/22 08:07, Archimedes Gaviola wrote:
> >>> ugen1.5: <EPSON EPSON UB-U03II> at usbus1
> >>> ulpt1 on uhub1
> >>> ulpt1: <EPSON EPSON UB-U03II, class 0/0, rev 1.10/2.00, addr 5> on
> usbus1
> >>> device_attach: ulpt1 attach returned 12
> >>
> >> 12 : man errno :
> >> 12 ENOMEM Cannot allocate memory.
> >>
> >> I guess the EPSON printer you've got is not compatible with ulpt<n>
> >>
> >> When printing, can you make sure that the length transferred is never a
> >> multiple of 64 bytes?
> >>
> >> Also, there might be a bug lurking in the USB host controller driver,
> >> like already mentioned.
> >>
> >
> >
> > Hi Hans,
> >
> > I just figured-out the ulpt(4) driver in my Epson printer while comparing
> > with my Xprinter printer's USB device info. My Epson printer is providing
> > vendor specific values of 255 in the bInterfaceClass and
> bInterfaceSubClass
> > respectively.
> >
> > bInterfaceClass = 0x00ff <Vendor specific>
> > bInterfaceSubClass = 0x00ff
> >
> > It should be a value of 7 for bInterfaceClass and a value of 1 in
> > bInterfaceSubClass.
> >
> > bInterfaceClass = 0x0007 <Printer device>
> > bInterfaceSubClass = 0x0001
> >
> > So, the ulpt_attach() routine below will break upon validation for
> > mismatched values in UICLASS_PRINTER and UISUBCLASS_PRINTER.
> >
> > } else {
> > alt_index++;
> > if ((id->bInterfaceClass ==
> > UICLASS_PRINTER) &&
> > (id->bInterfaceSubClass ==
> > UISUBCLASS_PRINTER) &&
> > (id->bInterfaceProtocol ==
> > UIPROTO_PRINTER_BI)) {
> > goto found;
> > }
> > }
> >
> > What I did is temporarily replace these values in the USB definition. In
> > this case, how should the project handle this non-compliance USB devices?
> > Though I will raise this to Epson if they could provide an updated
> firmware.
> >
> > freebsd@generic:~ % diff -Nur /usr/src/sys/dev/usb/usb.h.orig
> > /usr/src/sys/dev/usb/usb.h
> > --- /usr/src/sys/dev/usb/usb.h.orig 2022-03-27 02:55:01.319235000
> +0800
> > +++ /usr/src/sys/dev/usb/usb.h 2022-03-27 02:57:10.608518000 +0800
> > @@ -459,8 +459,10 @@
> > #define UICLASS_PHYSICAL 0x05
> > #define UICLASS_IMAGE 0x06
> > #define UISUBCLASS_SIC 1 /* still image class */
> > -#define UICLASS_PRINTER 0x07
> > -#define UISUBCLASS_PRINTER 1
> > +/* #define UICLASS_PRINTER 0x07 */
> > +/* #define UISUBCLASS_PRINTER 1 */
> > +#define UICLASS_PRINTER 0xff
> > +#define UISUBCLASS_PRINTER 0xff
> >
> > I can print now with ulpt(4) driver but need further testing for any
> issues.
> >
> > ugen1.5: <EPSON EPSON UB-U03II> at usbus1
> > ulpt0 on uhub1
> > ulpt0: <EPSON EPSON UB-U03II, class 0/0, rev 1.10/2.00, addr 5> on usbus1
> > ulpt_attach: setting alternate config number: 0
> > ulpt0: using bi-directional mode
> >
>
> Hi,
>
> I think you can just extend that piece of code to accept either value
> using a boolean OR, ||.
>
Hi Hans,
Ah okay, this is noted. I just thought it's not allowed. I already extended
the code and on the way re-building the kernel.
Thanks,
Archimedes
--00000000000055ff3005db3402bb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 27, 2022 at 5:05 PM Hans =
Petter Selasky <<a href=3D"mailto:hps@selasky.org">hps@selasky.org</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 3/2=
7/22 07:55, Archimedes Gaviola wrote:<br>
> On Sat, Mar 12, 2022 at 4:41 PM Hans Petter Selasky <<a href=3D"mai=
lto:hps@selasky.org" target=3D"_blank">hps@selasky.org</a>> wrote:<br>
> <br>
>> On 3/12/22 08:07, Archimedes Gaviola wrote:<br>
>>> ugen1.5: <EPSON EPSON UB-U03II> at usbus1<br>
>>> ulpt1 on uhub1<br>
>>> ulpt1: <EPSON EPSON UB-U03II, class 0/0, rev 1.10/2.00, add=
r 5> on usbus1<br>
>>> device_attach: ulpt1 attach returned 12<br>
>><br>
>> 12 : man errno :<br>
>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 12 ENOMEM Cannot allocate memory.<br>
>><br>
>> I guess the EPSON printer you've got is not compatible with ul=
pt<n><br>
>><br>
>> When printing, can you make sure that the length transferred is ne=
ver a<br>
>> multiple of 64 bytes?<br>
>><br>
>> Also, there might be a bug lurking in the USB host controller driv=
er,<br>
>> like already mentioned.<br>
>><br>
> <br>
> <br>
> Hi Hans,<br>
> <br>
> I just figured-out the ulpt(4) driver in my Epson printer while compar=
ing<br>
> with my Xprinter printer's USB device info. My Epson printer is pr=
oviding<br>
> vendor specific values of 255 in the bInterfaceClass and bInterfaceSub=
Class<br>
> respectively.<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 bInterfaceClass =3D 0x00ff=C2=A0 <Vendor=
specific><br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 bInterfaceSubClass =3D 0x00ff<br>
> <br>
> It should be a value of 7 for bInterfaceClass and a value of 1 in<br>
> bInterfaceSubClass.<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 bInterfaceClass =3D 0x0007=C2=A0 <Printe=
r device><br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 bInterfaceSubClass =3D 0x0001<br>
> <br>
> So, the ulpt_attach() routine below will break upon validation for<br>
> mismatched values in UICLASS_PRINTER and=C2=A0 UISUBCLASS_PRINTER.<br>
> <br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 } else {<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 alt_index++;<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((id->bInterfaceClas=
s =3D=3D<br>
> UICLASS_PRINTER) &&<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (id->bInt=
erfaceSubClass =3D=3D<br>
> UISUBCLASS_PRINTER) &&<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (id->bInt=
erfaceProtocol =3D=3D<br>
> UIPROTO_PRINTER_BI)) {<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 goto found;<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 }<br>
> <br>
> What I did is temporarily replace these values in the USB definition. =
In<br>
> this case, how should the project handle this non-compliance USB devic=
es?<br>
> Though I will raise this to Epson if they could provide an updated fir=
mware.<br>
> <br>
> freebsd@generic:~ % diff -Nur /usr/src/sys/dev/usb/usb.h.orig<br>
> /usr/src/sys/dev/usb/usb.h<br>
> --- /usr/src/sys/dev/usb/usb.h.orig=C2=A0 =C2=A0 =C2=A02022-03-27 02:5=
5:01.319235000 +0800<br>
> +++ /usr/src/sys/dev/usb/usb.h=C2=A0 2022-03-27 02:57:10.608518000 +08=
00<br>
> @@ -459,8 +459,10 @@<br>
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UICLASS_PHYSICAL=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 0x05<br>
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UICLASS_IMAGE=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00x06<br>
>=C2=A0 =C2=A0#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UISUBCLASS_SIC=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 1=C2=A0 =C2=A0 =C2=A0 =C2=A0/* still image clas=
s */<br>
> -#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UICLASS_PRINTER=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A00x07<br>
> -#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UISUBCLASS_PRINTER=C2=A0 =C2=A0 =
=C2=A0 1<br>
> +/* #define=C2=A0 =C2=A0 =C2=A0UICLASS_PRINTER=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A00x07 */<br>
> +/* #define=C2=A0 =C2=A0 =C2=A0UISUBCLASS_PRINTER=C2=A0 =C2=A0 =C2=A0 =
1 */<br>
> +#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UICLASS_PRINTER=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A00xff<br>
> +#define=C2=A0 =C2=A0 =C2=A0 =C2=A0 UISUBCLASS_PRINTER=C2=A0 =C2=A0 =
=C2=A0 0xff<br>
> <br>
> I can print now with ulpt(4) driver but need further testing for any i=
ssues.<br>
> <br>
> ugen1.5: <EPSON EPSON UB-U03II> at usbus1<br>
> ulpt0 on uhub1<br>
> ulpt0: <EPSON EPSON UB-U03II, class 0/0, rev 1.10/2.00, addr 5> =
on usbus1<br>
> ulpt_attach: setting alternate config number: 0<br>
> ulpt0: using bi-directional mode<br>
> <br>
<br>
Hi,<br>
<br>
I think you can just extend that piece of code to accept either value <br>
using a boolean OR, ||.<br></blockquote><div><br></div><br></div><div class=
=3D"gmail_quote">Hi Hans,</div><div class=3D"gmail_quote"><br></div><div cl=
ass=3D"gmail_quote">Ah okay, this is noted. I just thought it's not all=
owed. I already extended the code and on the way re-building the kernel.</d=
iv><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">Thanks,<=
/div><div class=3D"gmail_quote">Archimedes<br></div></div>
--00000000000055ff3005db3402bb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJFbk7G8gUjBPLHJEGvU4SULCQP5eGhNATOW0-paRgz8pqcqQg>