From owner-freebsd-hackers@FreeBSD.ORG Fri Aug 4 23:42:14 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB58C16A4E2 for ; Fri, 4 Aug 2006 23:42:14 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.177]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2984B43D46 for ; Fri, 4 Aug 2006 23:42:13 +0000 (GMT) (envelope-from joao.barros@gmail.com) Received: by py-out-1112.google.com with SMTP id c59so286142pyc for ; Fri, 04 Aug 2006 16:42:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DtOod3DedhdMlW7CVbIqQksbmU8aWp0WP6btlD1J1Iu1q6G6xnR0l5xqNdKtnCS0F4LpuA2AjG4qsrC0V7lj7wWMaP/Q7PRxYFtmrZ4Xo/X83ef/ila2Cnfxi+JYbkoGee6mppbRAuC2r1RzKGZ33bqHJW6ewB8+o+IPopPPahQ= Received: by 10.35.66.12 with SMTP id t12mr5995123pyk; Fri, 04 Aug 2006 16:42:12 -0700 (PDT) Received: by 10.35.112.18 with HTTP; Fri, 4 Aug 2006 16:42:12 -0700 (PDT) Message-ID: <70e8236f0608041642v5c7a85a9u4e4422bb6f08822f@mail.gmail.com> Date: Sat, 5 Aug 2006 00:42:12 +0100 From: "Joao Barros" To: "Gleb Smirnoff" In-Reply-To: <20060804182123.GH96644@cell.sick.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com> <20060804150302.GD96644@cell.sick.ru> <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com> <20060804182123.GH96644@cell.sick.ru> Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] add header "pppoe:" in ng_pppoe.c printfs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 23:42:14 -0000 On 8/4/06, Gleb Smirnoff wrote: > On Fri, Aug 04, 2006 at 04:48:49PM +0100, Joao Barros wrote: > J> On 8/4/06, Gleb Smirnoff wrote: > J> >On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote: > J> >J> Being this a cryptic message to say the least and to probably save > J> >J> someone some time when presented with this message I attach a patch > J> >J> that adds the header "pppoe:" in every printf that didn't have it, > J> >J> making it consistent with the rest of the file. > J> > > J> >I've attached a patch that cleans a bit logging in ng_pppoe. It changes > J> >all printf(9) to log(9). The latter is better since it spams console > J> >less, if event occurs many times per second. Also I've made the messages > J> >more clear - prepended node ID where possible, function name when it > J> >starts with ng_pppoe, or just "ng_pppoe". > J> > > J> >Can you please try out this patch and tell whether you like it. If you > J> >do I will commit it soon. > J> > J> Hi, > J> > J> I've looked at the patch and it looks ok. > J> It serves the purpose: make the messages more clear with the added > J> bonus of more info. > J> Thanks for taking the time to look into this :-) > > Since I don't use ng_pppoe now much, I'd appreciate if you > do at brief test of this patch, before I commit it. > I patched and recompiled the kernel. After booting I notice that no messages from ppp are logged by syslog (messages|ppp.log) If I restart ppp the messages are all logged. I can't say if this was happening because after setting ppp up I didn't reboot the machine. I didn't browse the startup scripts but maybe syslog is not started before pppoe. Now it will take more than 17 hours for the session limit to be exceeded and only then I can say how your patch worked out. I'll make an update then. -- Joao Barros