Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Aug 2014 12:45:23 +0000
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r270516 - head/sys/dev/drm2/i915
Message-ID:  <A9C38492-05C0-49E0-A9F0-D08E19E9143C@FreeBSD.org>
In-Reply-To: <201408250503.s7P53Axo057720@svn.freebsd.org>
References:  <201408250503.s7P53Axo057720@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 25 Aug 2014, at 05:03 , Adrian Chadd <adrian@freebsd.org> wrote:

> Author: adrian
> Date: Mon Aug 25 05:03:10 2014
> New Revision: 270516
> URL: http://svnweb.freebsd.org/changeset/base/270516
>=20
> Log:
>  i915 driver - enable opregion handle; program CADL.
>=20
>  add opregion handling for drm2 - which exposes some ACPI video =
configuration
>  pieces that some Lenovo laptop models use to flesh out which video =
device
>  to speak to.  This enables the brightness control in ACPI to work =
these models.
>=20
>  The CADL bits are also important - it's used to figure out which ACPI
>  events to hook the brightness buttons into.  It doesn't yet seem to =
work
>  for me, but it does for the OP.
>=20


This broke pc98:

@/contrib/dev/acpica/include/platform/acfreebsd.h:75:10: fatal error: =
'machine/acpica_machdep.h' file not found



>  Tested:
>=20
>  * Lenovo X230 (mine)
>  * OP: ASUS UX51VZ
>=20
>  PR:	190186
>  Submitted by:	Henry Hu <henry.hu.sh@gmail.com>
>  Reviewed by:	dumbbell
>=20
> Modified:
>  head/sys/dev/drm2/i915/i915_drv.h
>  head/sys/dev/drm2/i915/i915_irq.c
>  head/sys/dev/drm2/i915/intel_opregion.c
> =85



> Modified: head/sys/dev/drm2/i915/intel_opregion.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/dev/drm2/i915/intel_opregion.c	Mon Aug 25 03:02:38 2014	=
(r270515)
> +++ head/sys/dev/drm2/i915/intel_opregion.c	Mon Aug 25 05:03:10 2014	=
(r270516)
> @@ -32,6 +32,9 @@ __FBSDID("$FreeBSD$");
> #include <dev/drm2/i915/i915_drm.h>
> #include <dev/drm2/i915/i915_drv.h>
> #include <dev/drm2/i915/intel_drv.h>
> +#include <contrib/dev/acpica/include/acpi.h>
> +#include <contrib/dev/acpica/include/accommon.h>
> +#include <dev/acpica/acpivar.h>
>=20
> #define PCI_ASLE 0xe4
> #define PCI_ASLS 0xfc

=97=20
Bjoern A. Zeeb             "Come on. Learn, goddamn it.", WarGames, 1983




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A9C38492-05C0-49E0-A9F0-D08E19E9143C>