From owner-cvs-all Tue Jan 9 14:25: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from mass.osd.bsdi.com (dhcp45-24.dis.org [216.240.45.24]) by hub.freebsd.org (Postfix) with ESMTP id 0D7B137B400; Tue, 9 Jan 2001 14:24:32 -0800 (PST) Received: from mass.osd.bsdi.com (localhost [127.0.0.1]) by mass.osd.bsdi.com (8.11.1/8.11.1) with ESMTP id f09MbvJ01112; Tue, 9 Jan 2001 14:37:57 -0800 (PST) (envelope-from msmith@mass.osd.bsdi.com) Message-Id: <200101092237.f09MbvJ01112@mass.osd.bsdi.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Matt Jacob Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include bus.h In-reply-to: Your message of "Tue, 09 Jan 2001 10:17:49 PST." <200101091817.f09IHng10622@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 09 Jan 2001 14:37:57 -0800 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > mjacob 2001/01/09 10:17:49 PST > > Modified files: > sys/alpha/include bus.h > Log: > The alpha architecture is 64 bits, so bus_addr_t && bus_size_t should really > be 64 bits wide. The largest known current actual physical implementation > is 40 bits, so BUS_SPACE_MAXADDR should reflect this. It also seems to > me that BUS_SPACE_UNRESTRICTED should b ~0UL, not ~0. Where a constant is of a known type, one should avoid "UL" in favour of the real type, eg. (~(bus_addr_t)0). There's too much "long" in the bus code already. 8( All IMO. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message