From owner-svn-src-head@freebsd.org Tue Jul 25 17:27:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAF74CFDB33; Tue, 25 Jul 2017 17:27:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A3FEF848BA; Tue, 25 Jul 2017 17:27:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 4C84810AF01; Tue, 25 Jul 2017 13:27:33 -0400 (EDT) From: John Baldwin To: Kristof Provost Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r321370 - head/lib/libsysdecode Date: Tue, 25 Jul 2017 10:25:29 -0700 Message-ID: <2783492.qOfDobczBC@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <8FA5355F-E374-49BE-B2B2-25351ED827A9@FreeBSD.org> References: <201707221251.v6MCpKn4014224@repo.freebsd.org> <8FA5355F-E374-49BE-B2B2-25351ED827A9@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 25 Jul 2017 13:27:33 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2017 17:27:40 -0000 On Sunday, July 23, 2017 06:03:48 PM Kristof Provost wrote: > On 22 Jul 2017, at 17:42, Ngie Cooper (yaneurabeya) wrote: > > > On Jul 22, 2017, at 5:51 AM, Kristof Provost wro= te: > >> > >> Author: kp > >> Date: Sat Jul 22 12:51:19 2017 > >> New Revision: 321370 > >> URL: https://svnweb.freebsd.org/changeset/base/321370 > >> > >> Log: > >> Handle WITH/WITHOUT_PF in libsysdecode > >> > >> Only filter out the PF ioctls if we're building without pf suppor= t. > >> Until now those were always filtered out, so truss did not show=20= > >> symbolic > >> names for pf ioctls. > > > > > > Hi Kristof! > > =09'MFC after:=091 week=E2=80=9D should have probably be added to t= his commit. > > =09This change should be MFCed to ^/stable/11 and probably ^/stable= /10=20 > > (in usr.sbin/kdump on 10:=20 > > https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?re= vision=3D291815&view=3Dmarkup#l25=20 > > ). >=20 > To be honest I wasn=E2=80=99t planning on MFCing this, because it=E2=80= =99s not a=20 > terribly important issue. > That said, if it=E2=80=99d be useful to you (or anyone else) I=E2=80=99= m certainly=20 > willing to do so. >=20 > I=E2=80=99m not sure how much the code changed between 10 and 11, but= MFC to=20 > 11 should be easy, and if the changes are not too extensive I can do = the=20 > merge to 10 as well. libsysdecode is not present in 10. In 10 you'd have to patch the kdump= mkioctls script and the truss and kdump Makefile's. I think it's proba= bly not worth the trouble to MFC to 10. 11 should probably merge fine, tho= ugh you'll have to tweak it since the previous change to remove the disk ha= ck can't be MFC'.d :( Your original version of the patch would be fine fo= r 11 though. --=20 John Baldwin