From owner-svn-src-head@freebsd.org Tue Jul 14 15:26:42 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E06AF366893; Tue, 14 Jul 2020 15:26:42 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5krd5yfMz3SHT; Tue, 14 Jul 2020 15:26:41 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qv1-f43.google.com with SMTP id e3so7633433qvo.10; Tue, 14 Jul 2020 08:26:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AkfDginwQr2FIESCfikWN+fp0SOzXnYypGrRd+YHfaM=; b=LD1EUZd9lhAFGxUYBZX/baIUwDIdXcNSa8wfwCxEOFTOSEsZPkNtt8PkLcLpG29d+m CcxB2Tr79MPsCawVY0mpbYWQZo6qsMdzRYBx/i9r3ubISU9Ij9lRQtfGPYoXpGjfFU8b B6aSLkEU8wBJD9PR0UmGYQgJ6BAGTUnmEVW74Zq9uzqn2SakvlVe0OXTkzf6nm0d9Iur k1ng30Dv894J5DtWF0T3BUpjQQw+x9SJFJ1rlQNZLdyt4SDxNTZ1TcHC+a7Fcdo1h+Hp q1UvDfAc1YfULnbtAweTiTItt7+hSm9muKXiP7wZ5i4d8YembSVueGBxBD8Jpcdsob+m +HfA== X-Gm-Message-State: AOAM533hBpnhjJTBEpEX76FGd8HzsEVyfG6lpWmc9WkgQNeCCyRwlnDO JQkLPY6WrDJH0COyNCtZigkKowLNLCAMPAJ/pQo= X-Google-Smtp-Source: ABdhPJy6SkK+mRh2kBg5+TxtUQ4nb8ZxSGWqiHUjvKAG6IxWu5osF+1poMNBvFsOeV3/rGu8LpkRbm3NWAIPEoS2Uhw= X-Received: by 2002:ad4:4812:: with SMTP id g18mr5078832qvy.56.1594740399847; Tue, 14 Jul 2020 08:26:39 -0700 (PDT) MIME-Version: 1.0 References: <202007140502.06E52IZn022859@repo.freebsd.org> In-Reply-To: From: Adrian Chadd Date: Tue, 14 Jul 2020 08:26:28 -0700 Message-ID: Subject: Re: svn commit: r363172 - head/contrib/bc/src To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4B5krd5yfMz3SHT X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of adrianchadd@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=adrianchadd@gmail.com X-Spamd-Result: default: False [-1.52 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.58)[-0.578]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.80)[-0.797]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.15)[-0.147]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.43:from]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.43:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 15:26:43 -0000 On Tue, 14 Jul 2020 at 06:42, Warner Losh wrote: > Did you intend to commit to contrib software that has an active upstream? > This is going to cause conflicts in the future. Maybe you can submit it to > the new upstream instead? > i was going to do both, for the changes to both flex and bc. -adrian > > Warner > > On Mon, Jul 13, 2020 at 11:02 PM Adrian Chadd wrote: > >> Author: adrian >> Date: Tue Jul 14 05:02:18 2020 >> New Revision: 363172 >> URL: https://svnweb.freebsd.org/changeset/base/363172 >> >> Log: >> [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. >> >> I guess this didn't like the case statements.. ? But this does quieten >> the compiler error. >> >> Modified: >> head/contrib/bc/src/program.c >> >> Modified: head/contrib/bc/src/program.c >> >> ============================================================================== >> --- head/contrib/bc/src/program.c Tue Jul 14 05:00:08 2020 >> (r363171) >> +++ head/contrib/bc/src/program.c Tue Jul 14 05:02:18 2020 >> (r363172) >> @@ -180,7 +180,7 @@ static inline BcVec* bc_program_vec(const BcProgram *p >> >> static BcNum* bc_program_num(BcProgram *p, BcResult *r) { >> >> - BcNum *n; >> + BcNum *n = NULL; >> >> switch (r->t) { >> >>