From owner-freebsd-current@FreeBSD.ORG Thu Apr 22 13:34:17 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4B4F106566C; Thu, 22 Apr 2010 13:34:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 886428FC13; Thu, 22 Apr 2010 13:34:17 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 3C91446B85; Thu, 22 Apr 2010 09:34:17 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 95F3D8A021; Thu, 22 Apr 2010 09:34:11 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Thu, 22 Apr 2010 09:26:23 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004220926.23593.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 22 Apr 2010 09:34:11 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Gordon Tetlow Subject: Re: newsyslog patch implementing file includes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2010 13:34:17 -0000 On Wednesday 21 April 2010 11:55:44 pm Gordon Tetlow wrote: > I wanted the ability for a port to have a rotating log policy so I wrote a > patch for newsyslog to implement includes of other newsyslog.conf style > files. > > Please find the patch at: > http://people.freebsd.org/~gordon/patches/newsyslog.diff > > Format for the include line in /etc/newsyslog.conf is: > /etc/defaults/newsyslog.conf > > Here's a quick overview of the changes: > Convert the conf_entry struct from using a home rolled linked list to the > queue(3) macros. > Add a STAILQ to process include files. > Add support for tag to specify include files. > Globbing is supported in statements. > Properly detect circular include loop dependencies. > > Please take a look and send me any comments you might have. This is a great feature! One suggestion, I think this text in the new manpage isn't quite right: Name of the system log file to be archived, the literal string "default", or "include". I think it's ambiguous about "include" also being a literal string. Two possible suggestions: Name of the system log file to be archived, or one of the literal strings "default" or "include". Name of the system log file to be archived, the literal string "default", or the literal string "include". -- John Baldwin