From nobody Mon Jul 4 23:38:03 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 371B91D06EED; Mon, 4 Jul 2022 23:39:02 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LcMhQ0gCDz4RJ1; Mon, 4 Jul 2022 23:39:02 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656977942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fTVQQo9zisEFjjt6g9vmau4Js08xCbm7pr7ew+dKMWg=; b=gh25HxTCPWjwvRSN1dLHZi5HThpV9dCn9/MROzT9G9J7E9kdqwrBCH4L/UDrmuj5JUtKEC RCe3z8K3SBqzjKBSFvUAdeCbFECjsCMuj7Jh+hTSnc4ZunfLXxJUVyI7lFg2LPx5QxwFHx hyAYBzoHCZFE5wO7mM2BxVHdxwTQl7Qic2/R0HTNKDGRiEBaZE6AHo4e7lMPRD+mwN/pdv ow+2MQU2DWvqQuQ4B/Js4TpXbN8vD5vEGwTKuvGJFv2h97+zrR1Dl9b3B8HSQjinxYJj1e uELmCTQm8NYN0waQ0aYLB4rBmpnnaY7jy5Hj4HhC5mGJMfQgfl+UONrG7kL8WA== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D12F822AC8; Mon, 4 Jul 2022 23:39:01 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 73CAF8D4A161; Mon, 4 Jul 2022 23:38:59 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 78DECE707CA; Mon, 4 Jul 2022 23:38:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id utxkfBQD8_Zr; Mon, 4 Jul 2022 23:38:04 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 757EAE707AE; Mon, 4 Jul 2022 23:38:04 +0000 (UTC) Date: Mon, 4 Jul 2022 23:38:03 +0000 (UTC) From: "Bjoern A. Zeeb" To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 09cdf4878c62 - main - dwc3: add more quirks and checks In-Reply-To: <202207032219.263MJdDI051040@gitrepo.freebsd.org> Message-ID: References: <202207032219.263MJdDI051040@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656977942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fTVQQo9zisEFjjt6g9vmau4Js08xCbm7pr7ew+dKMWg=; b=YfmUD9Lu1jQ9ALi06tfIRMYAT98U5x8pgpg4wegCLs5OXagnm6dtM/VbNp5CzPVPThAqcv KZnGrTxS16V/yT9crHiEOOfZEyj1vBSfXFf5oLBZ4l2e+Pwr+sOty/SGtXIdmms3uT80Sj 4fDHEs68lC+7aZHHw62rWpn0gsD6a2x+9cXxycjDTfuXGR3+4rI+fmgJfqJ4RkFiypqYE1 kEBja3iinlKMeRXuWNDpyaeyMUznDYdSgqXAWpHv7RlJdJu75SlgPknxZyBQibhnJl+fxd AaGiJyFO3a4IJd6K5TWf7QeInOP4CTC8sAxuZipGdpwwJaaLHEyVxk5YaEJ3Kg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656977942; a=rsa-sha256; cv=none; b=PSAiwDAmxuhaqosP35bERx0Q3lHDhzRsmHbIechaSyQUxWOAyNW7hfgXWG9Ppaf0pBAt+E iNZZLf6zWZwCbQd0Ax9RvY3DSr9kJ+QD3uCgshCcRNACQZ2mqmGIGoMOYqPOsasVrUyA4D DIMVgo1evlDkYk5wJUEivpnk2hNyzXTKMpp+nFGKZfdzetFIxwhVIV3VcfIAkrDNM14GhD 2CiWXfFoW2fmjGpgfEw74Hq4wymMaoEhswBM0su9jNNNGlVKpDNgVEmRSq5gFp1UH8TdWD nmG74Wci73UH4ifzlScwtROdRxUH+1FNYkrPjww/k92IwzBPFyXfIskDQRjCkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sun, 3 Jul 2022, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=09cdf4878c621be4cd229fa88cdccdcdc8c101f7 > > commit 09cdf4878c621be4cd229fa88cdccdcdc8c101f7 > Author: Bjoern A. Zeeb > AuthorDate: 2022-07-02 20:56:07 +0000 > Commit: Bjoern A. Zeeb > CommitDate: 2022-07-03 22:17:35 +0000 > > dwc3: add more quirks and checks > > Rather than just printing the Global SNPS ID Register store it as well > so we can do a version check later. > In addition, for debugging purposes, read the Global Hardware Parameters > Registers and print them. > > Based on the snpsid disable an XHCI feature using a quirk prepared > in 447c418da03454a2a00bc115a69c62055a6d5272. > Add the "snps,dis_u3_susphy_quirk" quirk and handle Suspend USB3.0 SS PHY > after power-on-reset/during core initialization (suggested to be cleared) > based on the DWC3_GHWPARAMS0 register. > > MFC after: 2 weeks > Obtained from: an old debugging patch > Reviewed by: mw (earlier version), mmel > Differential Revision: https://reviews.freebsd.org/D35699 > --- > sys/dev/usb/controller/dwc3.c | 54 +++++++++++++++++++++++++++++++++++++++---- > sys/dev/usb/controller/dwc3.h | 3 +++ > 2 files changed, 53 insertions(+), 4 deletions(-) One of the changes here makes dwc3 fail now; you'll see an error about "Controller does not support 4K page size" from xhci.c. I am checking which part it was.. and where it slipped in. I guess the old debugging patch got rusty ... though I had booted the original one for months and still do on another not-yet-updated machine just fine. /bz -- Bjoern A. Zeeb r15:7