From owner-freebsd-current@FreeBSD.ORG Wed Mar 8 18:05:10 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6102416A420; Wed, 8 Mar 2006 18:05:10 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56ECB43D5A; Wed, 8 Mar 2006 18:05:09 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id k28I543G015113; Wed, 8 Mar 2006 13:05:04 -0500 (EST) Date: Wed, 8 Mar 2006 13:05:04 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Harti Brandt In-Reply-To: <20060308154805.D10582@beagle.kn.op.dlr.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: <20060308155647.Y10582@beagle.kn.op.dlr.de> X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , current@freebsd.org Subject: Re: When will bsnmp stop breaking -current builds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 18:05:10 -0000 On Wed, 8 Mar 2006, Harti Brandt wrote: > On Wed, 8 Mar 2006, Daniel Eischen wrote: > > DE>On Wed, 8 Mar 2006, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote: > DE> > DE>> Harti Brandt writes: > DE>> > I checked that gensnmptree does not generated these useless > DE>> > references since at least early 2001. > DE>> > DE>> The machine where I had this problem was running a two-week old > DE>> -CURRENT. > DE> > DE>Same here, give or take a few days. > > This seems to be exact the time when usr.sbin/bsnmp was detached from > world because of my misimport. This was from 2/14/2006 until 2/27/2006. > > I wonder how this happens... > > Ok. I think I got it. In Rev. 1.1.1.9 of gensnmptree.c I fixed a bug that > was discovered by jasone: the flag field of struct node was not > initialized to 0. This field contains the flags FL_GET and FL_SET. If bot= h > of them are zero, nothing is emitted for that node - this is what should > happen to the nodes that reference the op_*dummy() functions. Even with > this bug the code happend to work, because this location was 0 with > phkmalloc. With the new malloc code the flag field contains obviously a > non-zero value. So if you have an old gensnmptree (which may happen > because the build of it was detached from world for some time) and a new > malloc, you end up getting these references. > > But for this to happen the build process also must use the installed > gensnmptree (because the newly compiled one would not have this bug). > > Can one of you verify that the new gensnmptree does the right thing?: > > cd /usr/src/usr.sbin/bsnmpd/gensnmptree > make clean > make > cd /usr/src/contrib/bsnmp/snmpd > .../gensnmptree grep dymmy tree.c > rm tree.c tree.h > > Replace ... by the path to the fresh gensnmptree. yes, that seemed to work. There are no references to dummy in the generated tree file. --=20 DE