From nobody Mon Aug 5 18:44:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wd51w0T6yz5SVyM; Mon, 05 Aug 2024 18:44:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wd51v71qQz4tgd; Mon, 5 Aug 2024 18:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722883444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jkKI2o8zgS74e4Taef8aSsNV+0cXO+8E1jrsyjZgN0E=; b=FUBUz0/iW/vRaDSZL9+uasXtVSgshj5rVTK05q8Uz+PKwkYMTt2RrhRwU3iYrrSWYOVXuB dvBblqaPEAJUVLiNjCzAVSC8e9xrBIcuTHA7gXx2b5qWKlEfw8SwZhMYywNrKDHwntQpKL Hsf2dOJ8XzKxRv6UuJqlLqj77qDggJVBu2bhmkAk8vSvYqNXmBQAzfMe+F6B/HmOVorRS8 eWRuITDGYKVS8ipH8p4NyI9m2oZCBOxPm5qJkNdLbVjxGSmpXUS3f+Tl0gTsM/THwQ1Wgm HUmA0kFLH0er6OvrJ83zYLXLDL9Mq7H5MIZnaxMxOST2Biif7cLMD0EaW4+u+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722883444; a=rsa-sha256; cv=none; b=nl5T50KN35BVw3V3Vj1rlUIsyZmbcEcxAnGCOQfa9f7eaOsTsG+hHLwtw57/X/IJzCZ1t1 65ZsT60tGVzCJNl4DjyYqeIpkC7HY8u4Yl28GNwhK1Tv+HQcXjUi5gTkXZ/iQPP1a2WqZX HwKnBBsvz2okB4MUe3BMF7foNy1clX6ghu6HqsOCrP5KNO0r9YpRjaMqfevkP5XY1AraRM NxQuRZjJbw5CvjK6wyBdk1n/cd3xgF5LvrkzhLQYmmMXtRnQecsx/HvlzzxEOIBk5yc16+ GLucLQX9Xm47WHxFzgAaKhAOsxcWWmIE3WSpnQp2KFv573pYYwqxrA/sbNKwBA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722883444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jkKI2o8zgS74e4Taef8aSsNV+0cXO+8E1jrsyjZgN0E=; b=cxCM8tttFT8yd3iRE40Os36z0qTg0Og1rWZYSjzzft8OewIX127MEtxDG930399VXqBhe9 Gp3AsOTBnjarDhZVGz68Wm5SgzdIHe0dc7JF8EG+eaFU67hQCYB/7o7m5kSHtV05ng2Bk7 teakhgmhyEmcNpA0MiScLgfCAYOcl7jSzfQ1kJ7DMyYIXn1tI62KgFcGlN/vfW35NBVl9n CxXNhYu6hCkUNSg6O/HffvuH87Ox3cuCVrJDGvmD1gt7RTLnnWbxGAocuVzJGY9Zp/97n2 nodukSpzXck8ITwmpq1DCN9ZzBCQd2XwPIE9LCi5VZlK6HSh+9V9909SVpp5MQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wd51v6VdNzbHK; Mon, 5 Aug 2024 18:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 475Ii34c053456; Mon, 5 Aug 2024 18:44:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 475Ii3SS053453; Mon, 5 Aug 2024 18:44:03 GMT (envelope-from git) Date: Mon, 5 Aug 2024 18:44:03 GMT Message-Id: <202408051844.475Ii3SS053453@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 6cb8b61efe88 - main - calendar: don't setlogin(2) in the -a user handlers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6cb8b61efe8899ee9194563108d0ae90c1eb89e3 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=6cb8b61efe8899ee9194563108d0ae90c1eb89e3 commit 6cb8b61efe8899ee9194563108d0ae90c1eb89e3 Author: Kyle Evans AuthorDate: 2024-08-05 18:43:56 +0000 Commit: Kyle Evans CommitDate: 2024-08-05 18:43:56 +0000 calendar: don't setlogin(2) in the -a user handlers As of e67975d331 ("Fix 'calendar -a' in several ways."), `calendar -a` will now fork off a new process for each user and do all of its own processing in the user's own context. As a side-effect, calendar(1) started calling setlogin(2) in each of the forked processes and inadvertently hijacked the login name for the session it was running under, which was typically not a fresh session but rather that of whatever cron/periodic run spawned it. Thus, daily and security e-mails started coming from completely arbitrary user. We could create a new session, but it appears that nothing calendar(1) does really needs the login name to be clobbered; opt to just avoid the setlogin(2) call entirely rather than incur the overhead of a new session for each process. PR: 280418 Reviewed by: des, olce Fixes: e67975d331 ("Fix 'calendar -a' in several ways.") Differential Revision: https://reviews.freebsd.org/D46095 --- usr.bin/calendar/calendar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/calendar/calendar.c b/usr.bin/calendar/calendar.c index 7610ad034759..ebc8d7f5c35e 100644 --- a/usr.bin/calendar/calendar.c +++ b/usr.bin/calendar/calendar.c @@ -211,7 +211,7 @@ main(int argc, char *argv[]) lc = login_getpwclass(pw); if (setusercontext(lc, pw, pw->pw_uid, - LOGIN_SETALL) != 0) + LOGIN_SETALL & ~LOGIN_SETLOGIN) != 0) errx(1, "setusercontext"); setenv("HOME", pw->pw_dir, 1); cal();