From owner-svn-src-all@freebsd.org Mon Jan 22 12:59:10 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9411EBFF44; Mon, 22 Jan 2018 12:59:10 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 904BA7AD37; Mon, 22 Jan 2018 12:59:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 53b11d82; Mon, 22 Jan 2018 13:59:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=S4R8iJp5zSxm4RXAXHsY7Hit3EQ=; b=BK7nKdTFNV47UmgPPEz6H5uGp28g kt9rUwMlR0GCSCTv3u7c0E3UqQ+RJ57kBjcJKvFXfpnKccHRHQEBWQJTx6CBiHib RnkB6Q4Cl6UvCrVtzl9iGdyIv8Od5fN+g2cQ36L5n5IXqpozSVO1rtFZ1HHM14kX TwPZUdogtuDm4jI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=mleGRd0rXByu9sIyn/zWxFkcSRzezt5pE+nVadhzdosC79q5wXyLiE0/ D5bVCpkfaqUCAX0PSyM9beJZ7y6Gfb+M/9hazqmFa6N6IM6bRPGmzU8cYDw0JofF DUNVBWWttJ/mAiGkgyKY0WQpFprj3l25/phJngH1zpZ4JpRyj0Y= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id eef36079 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Mon, 22 Jan 2018 13:59:05 +0100 (CET) Date: Mon, 22 Jan 2018 13:59:05 +0100 From: Emmanuel Vadot To: Poul-Henning Kamp Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-Id: <20180122135905.203e19ce94510854777dff63@bidouilliste.com> In-Reply-To: <201801220710.w0M7AUm9091853@repo.freebsd.org> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 12:59:10 -0000 On Mon, 22 Jan 2018 07:10:30 +0000 (UTC) Poul-Henning Kamp wrote: > Author: phk > Date: Mon Jan 22 07:10:30 2018 > New Revision: 328257 > URL: https://svnweb.freebsd.org/changeset/base/328257 > > Log: > Add a skeleton Clock Manager for RPi2/3, and use that from pwm > instead of frobbing the registers directly. > > As a hack the bcm2835_pwm kmod presently ignores the 'status="disabled"' > in the RPI3 DTB, assuming that if you load the kld you probably > want the PWM to work. > > Added: > head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c (contents, props changed) > head/sys/arm/broadcom/bcm2835/bcm2835_clkman.h (contents, props changed) > Modified: > head/sys/arm/broadcom/bcm2835/bcm2835_pwm.c > head/sys/dts/arm/bcm2836.dtsi > head/sys/modules/Makefile > > bcm_pwm_probe(device_t dev) > { > > +#if 0 > + // XXX: default state is disabled in RPI3 DTB, assume for now > + // XXX: that people want the PWM to work if the KLD this module. > if (!ofw_bus_status_okay(dev)) > return (ENXIO); > +#endif This is really bad, one need to use overlay to enable the node. Leaving this I will predict that in the near futur you will have someone complaining that he set to load the module at boot, unplug is pwm testing gear and plug another type of HAT and that it makes funny thing. Can you please revert this part ? -- Emmanuel Vadot