From owner-freebsd-ports@freebsd.org Mon Dec 10 15:27:10 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 686671329EE4 for ; Mon, 10 Dec 2018 15:27:10 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [IPv6:2001:8b0:151:1:c4ea:bd49:619b:6cb3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D71F67DFDD; Mon, 10 Dec 2018 15:27:09 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from leaf.local (unknown [88.202.132.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: m.seaman@infracaninophile.co.uk) by smtp.infracaninophile.co.uk (Postfix) with ESMTPSA id AC63F785A; Mon, 10 Dec 2018 15:27:08 +0000 (UTC) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: smtp.infracaninophile.co.uk/AC63F785A; dkim=none; dkim-atps=neutral Subject: Re: certbot lost certificates , and registration data To: koobs@FreeBSD.org, Paul Macdonald Cc: freebsd-ports@freebsd.org References: <4290f82e-ce3a-0ce3-aab7-df21a9c636e6@ifdnrg.com> <830576a4-78b8-6d74-8a40-19bf09ee6bdd@FreeBSD.org> <22ee5a0e-3093-15a2-4943-8e94ea449d1c@FreeBSD.org> From: Matthew Seaman Message-ID: <147aaf56-bc6d-e4cb-c62d-d4aeeef3df0c@FreeBSD.org> Date: Mon, 10 Dec 2018 15:27:08 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <22ee5a0e-3093-15a2-4943-8e94ea449d1c@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D71F67DFDD X-Spamd-Result: default: False [-3.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; ASN(0.00)[asn:20712, ipnet:2001:8b0::/32, country:GB]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 15:27:10 -0000 On 10/12/2018 14:54, Kubilay Kocak wrote: > On 11/12/2018 1:43 am, Matthew Seaman wrote: >> On 10/12/2018 14:10, Paul Macdonald via freebsd-ports wrote: >>> >>> On 10/12/2018 13:15, Paul Macdonald via freebsd-questions wrote: >>>> >>>> Is anyone else seeing py-certbot having lost all installed certs, >>>> and the initial registation data? >>>> >>>> There was an update on the 7th >>>> >>>> Upgrade of py27-certbot-0.28.0_1,1 to py27-certbot-0.29.1_1,1 >>>> >>>> and on 3 boxes tested so far, which all had certs, i now see no >>>> certs listed and a request to redo the initial registation on >>>> attempts to install a new cert. >>>> >>>> i don't see any issues upstream here: >>>> https://github.com/letsencrypt/boulder/issues/ so not sure if this >>>> is FBSD thing or not. >>>> >>>> Paul. >>> >>> >>> passing --config-dir /usr/local/etc/letsencrypt shows expected >>> output, i suspect something has happend with that flag on the upgrade >>> ( i see /etc/letsencrypt directories on affected servers) >>> >>> >>>> >>>> >> >> This upstream commit: >> >> https://github.com/certbot/certbot/commit/a23d76beb0e2c9539670766045314a5d50f582a2#diff-64ccdc74e8a07f9b039a6254093f1d0d >> >> >> breaks the post-patch target in the security/certbot port Makefile: >> >> post-patch: >>          @${REINPLACE_CMD} \ >>                  -e 's|/etc/|${LOCALBASE}/etc/|' \ >>                  -e 's|/var/lib|/var/db|' \ >>                  ${WRKSRC}/${PORTNAME}/constants.py >> >> Looks like the REINPLACE_CMD should be applied to >> ${WRKSRC}/${PORTNAME}/compat.py now. >> >> Or compat.py should be patched to grok FREEBSD_DEFAULT_FOLDERS >> >>      Cheers, >> >>      Matthew >> > > Nice find Matthew. > > Prefer the latter (and sent upstream). Can one of you create a bugzilla > issue for this and cc me please. > > If you'd like to give a representative/attempted patch a go, please do. > > ./koobs I'll take a look at this when I get home from work this evening. Cheers, Matthew