From owner-freebsd-bugs@FreeBSD.ORG Tue Nov 2 16:20:28 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4422616A4CE for ; Tue, 2 Nov 2004 16:20:28 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 163B743D4C for ; Tue, 2 Nov 2004 16:20:28 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iA2GKRcD029365 for ; Tue, 2 Nov 2004 16:20:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iA2GKR3W029363; Tue, 2 Nov 2004 16:20:27 GMT (envelope-from gnats) Resent-Date: Tue, 2 Nov 2004 16:20:27 GMT Resent-Message-Id: <200411021620.iA2GKR3W029363@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michiel Boland Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53E6616A4CE for ; Tue, 2 Nov 2004 16:11:06 +0000 (GMT) Received: from smtp-vbr9.xs4all.nl (smtp-vbr9.xs4all.nl [194.109.24.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FD6943D2D for ; Tue, 2 Nov 2004 16:11:05 +0000 (GMT) (envelope-from michiel@boland.org) Received: from xs6.xs4all.nl (xs6.xs4all.nl [194.109.21.6]) by smtp-vbr9.xs4all.nl (8.12.11/8.12.11) with ESMTP id iA2GB3Z1080915 for ; Tue, 2 Nov 2004 17:11:03 +0100 (CET) (envelope-from michiel@boland.org) Received: from xs6.xs4all.nl (boland37@localhost.xs4all.nl [127.0.0.1]) by xs6.xs4all.nl (8.12.10/8.12.10) with ESMTP id iA2GB3RK097796 for ; Tue, 2 Nov 2004 17:11:03 +0100 (CET) (envelope-from michiel@boland.org) Received: (from boland37@localhost) by xs6.xs4all.nl (8.12.10/8.12.9/Submit) id iA2GAw0d097702 for FreeBSD-gnats-submit@freebsd.org; Tue, 2 Nov 2004 17:10:58 +0100 (CET) (envelope-from michiel@boland.org) Message-Id: <200411021610.iA2GAw0d097702@xs6.xs4all.nl> Date: Tue, 2 Nov 2004 17:10:58 +0100 (CET) From: Michiel Boland To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/73423: stty -sane disables echo X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2004 16:20:28 -0000 >Number: 73423 >Category: bin >Synopsis: stty -sane disables echo >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 02 16:20:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Michiel Boland >Release: FreeBSD 6.0-CURRENT i386 >Organization: >Environment: System: FreeBSD leefnet.office.internl.net 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Tue Nov 2 14:55:25 CET 2004 root@leefnet.office.internl.net:/usr/obj/usr/src/sys/LEEFNET i386 >Description: After 'stty sane' is executed, the terminal no longer echos. >How-To-Repeat: Type 'stty sane' >Fix: --- /usr/src/bin/stty/key.c Tue Apr 6 22:06:53 2004 +++ key.c Tue Nov 2 17:02:57 2004 @@ -263,7 +263,7 @@ ip->t.c_iflag |= ICRNL; /* preserve user-preference flags in lflag */ #define LKEEP (ECHOKE|ECHOE|ECHOK|ECHOPRT|ECHOCTL|ALTWERASE|TOSTOP|NOFLSH) - ip->t.c_lflag = TTYDEF_LFLAG | (ip->t.c_lflag & LKEEP); + ip->t.c_lflag = TTYDEF_LFLAG_ECHO | (ip->t.c_lflag & LKEEP); ip->t.c_oflag = TTYDEF_OFLAG; ip->set = 1; } >Release-Note: >Audit-Trail: >Unformatted: