Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Feb 1998 12:27:34 -0500 (EST)
From:      Tim Vanderhoek <ac199@hwcn.org>
To:        Satoshi Asami <asami@FreeBSD.ORG>
Cc:        chuckr@glue.umd.edu, obrien@NUXI.com, ports@FreeBSD.ORG
Subject:   Re: cvs commit: ports/print/c2ps Makefile
Message-ID:  <Pine.BSF.3.96.980228121711.191D-100000@localhost>
In-Reply-To: <199802280114.RAA18850@vader.cs.berkeley.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 27 Feb 1998, Satoshi Asami wrote:

> So, the idea is to have <port>-<papersize> directories instead of
> <port> that we have currently.  People just cd into those and type
> "make install", and it will compile and install that version.  For the 

<port>-<papersize> should, of course, ignore any variables
instructing do use something other than <papersize>

Do we want a <port>-<papersize> for every papersize supported by
the port?  (assumed answer for remainder of message is "yes" :).


> What do we do with PAPERSIZE?  The nice thing about the current
> setting is that you can type "make install" from ports/print and get
> everything set up correctly if you have that variable defined.

Code to do try and find a <port>-<${PAPERSIZE}> when only the
<port> Makefile is run could be added to bsd.port.mk.

The ports currently using PAPERSIZE tend to have _otherwise_
smallish Makefiles (ie. not too many extract/patch/build hacks
needed).  I would expect this trend to continue.  All the real
info can be duplicated in each <port>-<papersize> Makefile
leaving <port> as nothing more than a placeholder. 

Even if a port which needs extensive hacks comes-up, there's
always scripts/, which can be shared instead of the Makefile.


> print/a2ps-letter/Makefile:
> ===
>  :
> .if defined(PAPERSIZE) && ${PAPERSIZE} != letter
> BROKEN=	This port is for Letter-sized printerheads.  Go to ${PORTSDIR}/print/a2ps-a4 for A4 paper size.
> .endif

Code like this should really really really be moved to
bsd.port.mk!


--
 tIM...HOEk
OPTIMIZATION: the process of using many one-letter variables names
              hoping that the resultant code will run faster.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980228121711.191D-100000>