From nobody Sat Oct 4 00:57:31 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdnF91sXdz69fJx; Sat, 04 Oct 2025 00:57:33 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdnF918kwz3Xwm; Sat, 04 Oct 2025 00:57:33 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759539453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bY0SAo62aD2uaIalWI1HqqzaA5b4CvMmEeoF7jgHS6g=; b=tDwV7m5+OIheoc5aSQq/n2k9xUIZu371QehYw36IGi4+LzfNBeK+Eabvtq842b9tCvwQFO 6kSIn1URyb1EHMTJEcgUykpYiEEkExVkAGH4/hvuw8nYOVg9rSjvrXJ0VdKnG8Xy6IlrDM m418dlTX48p5zUGyPL5i2t7CAzfp88seUvEAMsXwnMWBYRWNUhCme/mj2t/+fGxunsRowa mLuz95IaMTnOHt/rd7nkAZd1GzkqdTDtO75yMHThJ2WTfXHlOSjL4WImS3Nui7puS48zpJ 7iXA0QHFPvEcUx9zn4/YrE8mE6xgoDEZPMYIKKvCdLhw933knOqcNE9QN9rSBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759539453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bY0SAo62aD2uaIalWI1HqqzaA5b4CvMmEeoF7jgHS6g=; b=h+ujBT5aBbGq27sW4fWyvVGigyfpv+cY7wtQpUwFCFqg070pojj8HYtz7wnuzmCtRBRTso 48ige2uJYpuSVkhZnGqoevS3qFKgpRYrajj4K9VwlUuX4SNdLl7tGQ8HZ5MC13PTVxQGA+ wQ88DeBnLeoJ7hooL3gE/MM6vegmH7PbKPRtQhjhgzDwyTcEbTzVnvshBa+9Zqrei0VgXy smltvnaDgcJTdk2fhYPmak8lxCXYcvhMNq3CcGFKBcKQHUYf9v4zJzyZC4E1Rrq0ASc+13 RiTeGF/fjY/r2MXcAsZ5AOhsZdilbzeJA+VsBIaseOxUMWDiszQKPyo+ZwVvbA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759539453; a=rsa-sha256; cv=none; b=TR2E9IJxzMGl/6KEPR+AlWcHPWM+96PhHZL0OB0NYoYKzgAY1lsxk1UPnqUpF1xYwUX5O9 orzJCZJTq8ZY/tso2iEvV4qemXZh05TsF7MbnPPlGrDsvM7DLn8ORr0zH8XHIVdb6L98yo jDRy9QbGi0mD/uOewN7G9kvEhf/C2Qn7U890jCyjNeG3pMPJwEgAXj/pOFocvNvyVNUYfi FTLAzH3wigPhjB7mRmitYy0hU7c/Ect6df1tN8P4STMjXDq6r7exuUGnPioDJsMRVqH7Gc IFZuQAfHIVbRFpW4HIN4Bm/vCC4RE8/3A6YBFX9h+M7EMV7HRDsA05LJ7DSYtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cdnF8557rzFDb; Sat, 04 Oct 2025 00:57:32 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Fri, 3 Oct 2025 19:57:31 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1953a12ee2cd - main - flua: support our flua modules in the bootstrap flua To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202510031810.593IAZE9008541@gitrepo.freebsd.org> <27098bd2-04e8-4ef7-8b8e-f7b170eb8151@FreeBSD.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/3/25 17:45, Mark Johnston wrote: > On Fri, Oct 03, 2025 at 04:44:38PM -0500, Kyle Evans wrote: >> On 10/3/25 16:39, Mark Johnston wrote: >>> On Fri, Oct 03, 2025 at 06:10:35PM +0000, Kyle Evans wrote: >>>> The branch main has been updated by kevans: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=1953a12ee2cde1afacb3e3f7612d89695c96e04f >>>> >>>> commit 1953a12ee2cde1afacb3e3f7612d89695c96e04f >>>> Author: Kyle Evans >>>> AuthorDate: 2025-10-03 18:09:03 +0000 >>>> Commit: Kyle Evans >>>> CommitDate: 2025-10-03 18:09:14 +0000 >>>> >>>> flua: support our flua modules in the bootstrap flua >>>> This version builds every module into the flua binary itself, since all >>>> of the bootstrap tools are built -DNO_SHARED. As a result, we also >>>> cannot dlsym(), so we can't really discover the names of our newly >>>> builtin modules. Instead, just build out a linker set with all of our >>>> luaopen_*() functions to register everything up-front. >>>> Building in all of the modules isn't strictly necessary, but it means >>>> that we have an example of how to add a bootstrap module everywhere you >>>> go and one doesn't need to consider whether bootstrap flua can use a >>>> module when writing scripts. On my build machine, the consequence on >>>> our binary size is an increase from around 1.6M -> 1.9M, which isn't >>>> really that bad. >>>> .lua modules can install into their usual path below $WORLDTMP/legacy >>>> and we'll pick them up automagically by way of the ctor that sets up >>>> LUA_PATH early on. >>>> Reviewed by: bapt, emaste >>>> Differential Revision: https://reviews.freebsd.org/D51890 >>> >>> This breaks cross-building from other OSes since linker.h and kenv.h >>> aren't available. I guess we can safely exclude those from the >>> bootstrap build? It could be done conditionally on ${.MAKE.OS} perhaps, >>> but it's probably better to be consistent. >> >> Hi, >> >> Hmm, yes- I think excluding libfreebsd and libjail doesn't make it much more >> difficult to reason about what's available in the bootstrap flua. >> >> re: cross-builds, yikes- I forgot that we'll end up bootstrapping flua there. I >> bet it's also broken without libyaml and libucl here: https://reviews.freebsd.org/D52894? > > I don't see any bootstrap build failures in an Ubuntu chroot after I > disable building libfreebsd. Let me know if you'd like me to submit a > patch for that. I backed all of it out for the time being, because testing with the github jobs pointed out something funky[0] with the for mach-o, and I don't want to stand in the way of breaking cross-builds for this at the moment. [0] https://github.com/kevans91/freebsd/actions/runs/18237117404/job/51932901152