From owner-svn-src-head@freebsd.org Wed Sep 2 06:16:19 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FBDC9C509B; Wed, 2 Sep 2015 06:16:19 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3D5CCCF; Wed, 2 Sep 2015 06:16:18 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wibz8 with SMTP id z8so53371858wib.1; Tue, 01 Sep 2015 23:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BZL2SCrbDyWvNrLkA26BEQGFcmxWMlHa0AmtQUABpWo=; b=EWFI2EcxWBCcJ9WynhoPORE2m/Ve4ipVMh0BDwkwN1DI4af8mbm8PbXbE4ZCyaZIgl TfBwgEVr+bqO+vWhz2+ylhgal+zqTAevLKU+VDMtsbOQyLXHYHPuocG7+/Ny1sl1BSm9 68I9rQ0pitnVDFS/Oi5eXhHvv6xSmuGjpG6KdCE5HksNrrFLJl2dutgCt/f8DRHDg8Gy ozQ3jvX8buDhtlLH3OFFYbx8jcey+SG89s/ClPS8CWSEa/n2nui7p4VGUy3fjW1TXFYN TqIPLM0wZYmY1JWe85tHg+/L0CPYa/SUyBG28e7VivWbNseNdUyjfnqIkGHmyZQt8M2+ RQKw== X-Received: by 10.194.185.146 with SMTP id fc18mr37078088wjc.46.1441174577184; Tue, 01 Sep 2015 23:16:17 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id yu4sm30599255wjc.43.2015.09.01.23.16.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Sep 2015 23:16:16 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 2 Sep 2015 08:16:14 +0200 From: Baptiste Daroussin To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287366 - head/sys/kern Message-ID: <20150902061614.GB61752@ivaldir.etoilebsd.net> References: <201509011405.t81E5U0g025928@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eAbsdosE1cNLO4uF" Content-Disposition: inline In-Reply-To: <201509011405.t81E5U0g025928@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 06:16:19 -0000 --eAbsdosE1cNLO4uF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 01, 2015 at 02:05:30PM +0000, Konstantin Belousov wrote: > Author: kib > Date: Tue Sep 1 14:05:29 2015 > New Revision: 287366 > URL: https://svnweb.freebsd.org/changeset/base/287366 >=20 > Log: > Exit notification for EVFILT_PROC removes knote from the knlist. In > particular, this invalidates the knote kn_link linkage, making the > SLIST_FOREACH() loop accessing undefined values (e.g. trashed by > QUEUE_MACRO_DEBUG). If the knote is freed by other thread when kq > lock is released or when influx is cleared, e.g. by knote_scan() for > kqueue owning the knote, the iteration step would access freed memory. > =20 > Use SLIST_FOREACH_SAFE() to fix iteration. > =20 > Diagnosed by: avg > Tested by: avg, lstewart, pawel > Sponsored by: The FreeBSD Foundation > MFC after: 2 weeks >=20 Thank you! that makes my package builders stable again! Best regards, Bapt --eAbsdosE1cNLO4uF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXmlC4ACgkQ8kTtMUmk6EwPYgCffTXrongm+5WcyqPlbDnbi0/F 50AAn3UFsEw08TLJKEXcg9hWwuur3Vzp =FFvj -----END PGP SIGNATURE----- --eAbsdosE1cNLO4uF--