From nobody Tue Mar 3 18:46:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQPt40tcSz6TTS5 for ; Tue, 03 Mar 2026 18:47:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQPt3437dz3TD5 for ; Tue, 03 Mar 2026 18:47:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-3597fea200dso2216782a91.3 for ; Tue, 03 Mar 2026 10:47:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772563626; cv=none; d=google.com; s=arc-20240605; b=QdByoChaB+geqInPP4EiRmlz50NG5O4m8qlXbrC0ERNnhJ4SQklMRgCigYO/irFzo2 v8MqH6I7lhHwOHTp+t8P58FInfgIyuo8MRspWYREmdFY3I5yErh7DkCOpYq7rTw+m02f BQVGyoNST1k5sG6IPu46WUDjeTw3vLqwdpOwtwuM9XgCjeJzswitxRu7MWpE+equTzYE FPWeabyDQrtxB2jHmU4yF6djJIt8wLpt0W+HE8FsdhjMV4Au/m1uEW6vFPqLYmpa9zCr /kBa47oRBPm5ggoViLB8YxSR8/XE3SHtQ+Rn18fvZTuCfZhmV7Ke16RSN8uSVDaWcF2j gYAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=oMq1lhjEuef5erMXhpz5bzkhXZNyHyRcJxuf0wDNgtQ=; fh=tiG9sVDs1aHi1dOW/B923Td4ePv1bi2FurNJ23cCoqg=; b=Zq5RXUXcv5sJ9F6aj86zE0Ss3KD5Wq5wG0UOKlhC+tx0x81LKkSpfjRudjpjovvgXG EkOim/NEMHzLZfTqF7kJJbDINAnyQZnpj92UNJqkWleQbzmI+e9suR/3UScwLmkCsMsg EVORID/9aW+CGwVzkK7NsJ/2shGchUdoFoiFXEulK6wE/UFFR0QIWxu1y6khArhuYWUh L14/2hDetSk7wv/GBvs4+GRMve/1ZtJkhw067ytS/+sMCDO+cLXcnm77Mt/TfI9NSgng z88MtbZUzaUfJKKSM9wghE6uJsF/sVIhlsjH4AnQBffh8rEaXEgSOke73GnEvHu4vImp Lzkw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1772563626; x=1773168426; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oMq1lhjEuef5erMXhpz5bzkhXZNyHyRcJxuf0wDNgtQ=; b=yd41UizTd/XPug7WQc6APYTWlwRSivj8TcLFlwa+K+eisWU3z/FqJsUn4PV0pXw1HA yDjlBw5KTgjh7tpNgI06voZYv8w734uuwNvg115tBPg0+eeEfrgGpP38S9V0pTh/qJDb OTyXDFSLUnvZZx6cdCP935eySSDaey8xo21Gd8jUe7jX2YUWZqoHZSjnHgu+OmMEOiS6 yLLWWR6OW/KS9drQV0zKbFXuVWUlOjmNvNAQCEe/MyO4P7EjCsDZkSFDGEs8CBFS7zM2 yy9ZPGrqkpwVL1adpJM/jUY/IceIRnWbNHf1E83fNDuy/JWnPR08Xu9A9R/DSVmCDgeV gDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772563626; x=1773168426; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oMq1lhjEuef5erMXhpz5bzkhXZNyHyRcJxuf0wDNgtQ=; b=nwUNQZ1xlELE26XCsrrZQTT0hwYY/jLAcnLZNSPaA5Yw748PYZMbGqw3/CSKj6iCKr 7t0LnjS3rRyIyjw4p5hd6JgleWqf7yXRn3seUbjwvYtC8Gv5aIvlnFZtndlluatmWMjk 2Td5Sp6BPecHkqK92q3aSLaQHSMrtq4YS6bVdy/93Ky+uFHtFBt+iljm+udymaiFLwrM oi0ObbL7H32Jue4aJsslwlU2duO+obxWZPQGocDGo/LgkteIcjlzoqngcmVZEfzBXNYF qXg+AtgA2+3l2fEo6JiGqneCDDXH16LBXTmQcsRhW4HsF6OJy2EA+YDDny4mwICSSrYI EhNg== X-Forwarded-Encrypted: i=1; AJvYcCXRpRkGuCxDRCPiUWmDcGrgBpsODBVOIqXLP8OhjZ6gvoGhTpSdZzONanBnnVSoC5otYyeTIkU/xQpf6IfzPe9ZaqVA@freebsd.org X-Gm-Message-State: AOJu0YzoUeRG4y9MvTE7xjdrGd3FbDhD18YVug7/BrrrWdTJkUHe76ij 0QIuuWNW9GqIBi1eQa/P/vFHuveqzuWTs+KZ3x/A+YNpjxGlfhUiKV1VCxeYe2RWmWdXFsMOyaz 4aHB4BnnyW87bJItb7IkdFl4uQg7X8zLnBb4r+yDsXA== X-Gm-Gg: ATEYQzxWye+VAssPzWQuqL2heggZv4zzr457EDhsoYqh/LXPJHcHZXBknQ6i8Sla9Xa A+DoYLrxdJnIgSo5HxJnBkgCVU4Onn89sGYddiSVqi5dzqck1yJxAnLugoP43P5FYCp190vSCbx 2u7s7un9VCwXy83gDGS24M2dO5yD87Svk9cyMNvmq/sa+Kvm4vEhjvrMCoCpGfGOGtu71eoDEVF us8kkcN21Wzh3KbSowZ3VXArVlOIPy2TFwVzmIbdh7/fH6LFKldlJXLenzOllIjG1kkQgDl4f7f S5b8Pts= X-Received: by 2002:a17:90b:2496:b0:359:7d76:5ead with SMTP id 98e67ed59e1d1-3597d765fe6mr7801114a91.3.1772563626379; Tue, 03 Mar 2026 10:47:06 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 3 Mar 2026 11:46:54 -0700 X-Gm-Features: AaiRm52H5II1DpgyXi46Ppbj8O047QxIkqjOt5f8t-8ha9l_ToPEAsnsnIgmsHA Message-ID: Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` To: "Enji Cooper (yaneurabeya)" Cc: Brooks Davis , Enji Cooper , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000004ad9b0064c2321a5" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQPt3437dz3TD5 X-Spamd-Bar: ---- --0000000000004ad9b0064c2321a5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 3, 2026 at 11:17=E2=80=AFAM Enji Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On Mar 3, 2026, at 4:22=E2=80=AFAM, Warner Losh wrote: > > > > On Tue, Mar 3, 2026 at 5:18=E2=80=AFAM Brooks Davis wrote: > > On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > > > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper wrote: > > > > > > > The branch main has been updated by ngie: > > > > > > > > URL: > > > > > https://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80= 528f588eb > > > > > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > > > Author: Enji Cooper > > > > AuthorDate: 2026-03-03 05:59:50 +0000 > > > > Commit: Enji Cooper > > > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > > > > > Run `make obj` before running `make test-includes` > > > > > > > > Before this change, `make test-includes` (run as part of > buildworld) > > > > would place test files in the current directory, which would > clutter up > > > > git clones. Run `make obj` beforehand to ensure that the files > are put > > > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on > the > > > > noise significantly when running commands like `git status`. > > > > > > > > > > I've never seen this happen. .OBJDIR is created automatically for me > always > > > for the last 5 years... I run buildworld all the time. Can you explai= n > when > > > / how it happens more specifically or back out the change? > > > > The commit message is unintentionally misleading and incomplete. I hit > > the problem a week or so ago when fixing gcc12 builds and lacked the > > time to follow up. test-includes is fine as part of buildworld, but > > when run directly from src does fill tools/build/test-includes with .c > > files if you blow away the objdir (which seems to the the only reliably > > way to cause test-includes to retest some more complex cases.) > > > > Ah! That should have been in the commit message as the edge case > > that provoked this. That's a decent explanation, though there's other > > bits of buildworld that will also cause problems if you do them in > isolation > > and not part of buildworld. This one, though, is important enough to ma= ke > > an exception for, I think. It's one that's most likely to be used in > isolation. > > Hi Warner, > > I consistently run into this behavior when doing mfsbsd builds on my > 14.3-RELEASE host using this src.conf: https://reviews.freebsd.org/P702 . > MK_AUTO_OBJ=3Dyes as shown here: https://reviews.freebsd.org/P703 . > > I always run this target as part of buildworld on my 14.3-RELEASE host, s= o > whatever is working on your end is likely an artifact of the build host > environment, whereas what=E2=80=99s not working for me like you expect is= an > artifact of my build host environment. > > This: > > > Before this change, `make test-includes` (run as part of buildworld) > > would place test files in the current directory, which would clutter up > > git clones. > > > Could more accurately be expressed like this: > > > Before this change, `make test-includes` (run as part of buildworld) > > would place test files in the current directory on my 14.3-RELEASE > > build host, which would clutter up git clones. > > > The exact reason why there=E2=80=99s a difference eludes me right now. > The likely reason is that you explicitly ran `make test-includes` without first running `buildworld` to create the objdir. As part of buildworld, it always creates the right thing. Or there's some other partial evaluation. That's the only way I could recreate it, and only if I turned off metamode. PS I was waiting for a response to the Differential for over a week; I > landed the change because I hadn=E2=80=99t received feedback on the revie= w in that > period of time and because it gets really old quickly having to always do > `git status -uno` in my clones to make sure I=E2=80=99m not accidentally = committing > things that shouldn=E2=80=99t be committed. This is especially annoying w= hen doing > rebases with my =E2=80=9CMac=E2=80=9D dev branch because it has a lot of = overlapping > sections of code in asmc(4) and thunderbolt(4). Yea, you didn't ping me on it. I've got a lot going on... There's a lot of requests with my name on it and w/o an explicit ping, I can often miss them. It's not wrong, per se, but the commit message was incorrect and overly broad. Brooks showed me a way to recreate it, which I did, but I couldn't otherwise create this with either meta mode on or off. I doubt that cross-version builds would cause it too, but I suppose it might. I do get the annoyance. And it all worked out: I found a way to trigger this, even if it isn't what you are hitting. Warner --0000000000004ad9b0064c2321a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 3, = 2026 at 11:17=E2=80=AFAM Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:

> On Mar 3, 2026, at 4:22=E2=80=AFAM, Warner Losh <imp@bsdimp.com> wrote:
>
> On Tue, Mar 3, 2026 at 5:18=E2=80=AFAM Brooks Davis <brooks@freebsd.org> wrote:=
> On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote:
> > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <ngie@freebsd.org> wrote:
> >
> > > The branch main has been updated by ngie:
> > >
> > > URL:
> > > htt= ps://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba80528f5= 88eb
> > >
> > > commit 912864912b71951f9a636190b1dba80528f588eb
> > > Author:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org&= gt;
> > > AuthorDate: 2026-03-03 05:59:50 +0000
> > > Commit:=C2=A0 =C2=A0 =C2=A0Enji Cooper <ngie@FreeBSD.org&= gt;
> > > CommitDate: 2026-03-03 05:59:56 +0000
> > >
> > >=C2=A0 =C2=A0 =C2=A0Run `make obj` before running `make test-= includes`
> > >
> > >=C2=A0 =C2=A0 =C2=A0Before this change, `make test-includes` = (run as part of buildworld)
> > >=C2=A0 =C2=A0 =C2=A0would place test files in the current dir= ectory, which would clutter up
> > >=C2=A0 =C2=A0 =C2=A0git clones. Run `make obj` beforehand to = ensure that the files are put
> > >=C2=A0 =C2=A0 =C2=A0in `${.OBJDIR}` instead of `${.CURDIR}`. = This helps cut down on the
> > >=C2=A0 =C2=A0 =C2=A0noise significantly when running commands= like `git status`.
> > >
> >
> > I've never seen this happen. .OBJDIR is created automatically= for me always
> > for the last 5 years... I run buildworld all the time. Can you ex= plain when
> > /=C2=A0 how it happens more specifically or back out the change?<= br> >
> The commit message is unintentionally misleading and incomplete.=C2=A0= I hit
> the problem a week or so ago when fixing gcc12 builds and lacked the > time to follow up.=C2=A0 test-includes is fine as part of buildworld, = but
> when run directly from src does fill tools/build/test-includes with .c=
> files if you blow away the objdir (which seems to the the only reliabl= y
> way to cause test-includes to retest some more complex cases.)
>
> Ah! That should have been in the commit message as the edge case
> that provoked this. That's a decent explanation, though there'= s other
> bits of buildworld that will also cause problems if you do them in iso= lation
> and not part of buildworld. This one, though, is important enough to m= ake
> an exception for, I think. It's one that's most likely to be u= sed in isolation.

Hi Warner,

I consistently run into this behavior when doing mfsbsd builds on my 14.3-R= ELEASE host using this src.conf: https://reviews.freebsd.org/P702 . MK_AUTO_OBJ=3Dyes as shown here: https://reviews.freebsd.org/P70= 3 .

I always run this target as part of buildworld on my 14.3-RELEASE host, so = whatever is working on your end is likely an artifact of the build host env= ironment, whereas what=E2=80=99s not working for me like you expect is an a= rtifact of my build host environment.

This:

> Before this change, `make test-includes` (run as part of buildworld) > would place test files in the current directory, which would clutter u= p
> git clones.


Could more accurately be expressed like this:

> Before this change, `make test-includes` (run as part of buildworld) > would place test files in the current directory on my 14.3-RELEASE
> build host, which would clutter up git clones.


The exact reason why there=E2=80=99s a difference eludes me right now.
<= /blockquote>

The likely reason is that you explicitly ra= n `make test-includes` without first running `buildworld` to create the obj= dir. As part of buildworld, it always creates the right thing. Or there'= ;s some other partial evaluation. That's the only way I could recreate = it, and only if I turned off metamode.

PS I was waiting for a response to the Differential for over a week; I land= ed the change because I hadn=E2=80=99t received feedback on the review in t= hat period of time and because it gets really old quickly having to always = do `git status -uno` in my clones to make sure I=E2=80=99m not accidentally= committing things that shouldn=E2=80=99t be committed. This is especially = annoying when doing rebases with my =E2=80=9CMac=E2=80=9D dev branch becaus= e it has a lot of overlapping sections of code in asmc(4) and thunderbolt(4= ).

Yea, you didn't ping me on it. I'= ;ve got a lot going on... There's a lot of requests with my name on it = and w/o an explicit ping, I can often miss them. It's not wrong, per se= , but the commit message was incorrect and overly broad. Brooks showed me a= way to recreate it, which I did, but I couldn't otherwise create this = with either meta mode on or off. I doubt that cross-version builds would ca= use it too, but I suppose it might.=C2=A0

I do get= the annoyance. And it all worked out: I found a way to trigger this, even = if it isn't what you are hitting.

Warner
=
--0000000000004ad9b0064c2321a5--