From owner-freebsd-current@FreeBSD.ORG Tue Nov 12 12:48:37 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B6778129; Tue, 12 Nov 2013 12:48:37 +0000 (UTC) Received: from mail.neelc.org (maya.neelc.org [72.0.227.50]) by mx1.freebsd.org (Postfix) with ESMTP id 918612959; Tue, 12 Nov 2013 12:48:37 +0000 (UTC) Received: from mail.neelc.org (maya.neelc.org [72.0.227.50]) by mail.neelc.org (Postfix) with ESMTPA id 96F3D1186F9A; Tue, 12 Nov 2013 07:48:36 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 12 Nov 2013 07:48:36 -0500 From: Neel Chauhan To: Konstantin Belousov Subject: Re: [PATCH] Haswell Kernel Mode Setting Mail-Reply-To: neel@neelc.org In-Reply-To: <20131112082932.GU59496@kib.kiev.ua> References: <52816A9A.4050305@delphij.net> <20131112082932.GU59496@kib.kiev.ua> Message-ID: <8f255aa45ade695995d53eafd939d35e@mail.neelc.org> X-Sender: neel@neelc.org User-Agent: Roundcube Webmail/0.9.5 X-Mailman-Approved-At: Tue, 12 Nov 2013 12:54:41 +0000 Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org, d@delphij.net X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: neel@neelc.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Nov 2013 12:48:37 -0000 On 2013-11-12 03:29, Konstantin Belousov wrote: > On Mon, Nov 11, 2013 at 03:39:06PM -0800, Xin Li wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA512 >> >> On 11/11/13 14:29, Neel Chauhan wrote: >> > Sorry if I sent a similar patch before. It didn't get accepted so I >> > am sending one now. Enjoy. >> >> What does "didn't get accepted" mean? :) Since this looks like a >> PCI-ID only change that do not affect other existing hardware, if it's >> not an explicit objection from a reviewer, I think it's Okay to just >> go ahead and commit the change after a reasonable timeout instead of >> waiting indefinitely. > > I very much doubt that this patch works. More, I believe that it was > not tested at all. Talking about the trivially obvious things, the PGTT > handling must be updated since page tables have different format > comparing > with Ivy, there are some changes to ring dispatching, and lot of > changes in the display pipeline. All this is missing from the patch. > > Oh, and the Series 8 chipset PCH detection is missing. I probably > should stop now. > > HSW support is much more than just adding the Ids, I am (slowly) > starting > the work on importing the Linux updates. Konstantin, Thanks for telling me. The reality is, I don't really know about the insides of the FreeBSD kernel, Linux, or drm. I just looked at a few files. I should really get a book about FreeBSD before trying to send patches again. And anyways, this patch is untested. I was in a rush to send it to the mailing list, hoping it would get accepted. Thanks, Neel