Date: Tue, 10 Oct 2000 19:48:16 +0900 From: "Akinori MUSHA" <knu@idaemons.org> To: reg@FreeBSD.ORG Cc: asami@FreeBSD.ORG, yasuf@bsdclub.org, leeym@bsd.ce.ntu.edu.tw, kevlo@FreeBSD.ORG, ade@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: New order check done Message-ID: <86itr1dlan.wl@archon.local.idaemons.org> In-Reply-To: In your message of "Mon, 9 Oct 2000 23:59:00 -0700" <20001009235900.N30468@shale.csir.co.za> References: <200010092150.e99LokA95039@silvia.hip.berkeley.edu> <86og0twic9.wl@archon.local.idaemons.org> <20001009235900.N30468@shale.csir.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
At Mon, 9 Oct 2000 23:59:00 -0700,
Jeremy Lea <reg@FreeBSD.ORG> wrote:
> On Tue, Oct 10, 2000 at 11:17:10AM +0900, Akinori MUSHA wrote:
> > It was caused because someone removed the below line:
> >
> > CONFIGURE_ARGS= ${GTK_CONFIG}
> >
> > Ruby-gtk's configure script is _not_ a GNU one and it takes
> > gtk-config's name as the first command line argument followed by some
> > options that start with "--".
>
> Sorry, that was me. The configure script finds imlib-config if it is
> installed, so it was passing my test builds with WITHOUT_IMLIB=yes, and
> I couldn't find any use for the CONFIGURE_ARGS, since the port didn't
No problem. It's all fine now. :)
> define (HAS|GNU)_CONFIGURE. You might want to consider using
> EXTCONF_ARGS rather than reusing CONFIGURE_ARGS.
FYI, we have PERL_CONFIGURE which declares the port uses Makefile.PL
as configure script, and which uses CONFIGURE_ARGS. That shows
CONFIGURE_ARGS is used generally for the configure stage.
Ruby has currently two options of how to configure: USE_RUBY_EXCONF
declares that the port uses exconf.rb, and USE_RUBY_SETUP declares
that it uses setup.rb.
Anyway, bsd.gnome.mk does not need to set CONFIGURE_ARGS when neither
HAS_CONFIGURE or GNU_CONFIGURE is defined. It can just leave it to
the port.
> > diff -u -r1.15 Makefile
> > --- Makefile 2000/10/08 10:23:45 1.15
> > +++ Makefile 2000/10/10 01:52:45
> > @@ -15,14 +15,14 @@
> >
> > MAINTAINER= yasuf@bsdclub.org
> >
> > -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > -
> > USE_RUBY= yes
> > USE_RUBY_EXTCONF= yes
> > USE_XLIB= yes
> > USE_GTK= yes
> > WANT_IMLIB= yes
> >
> > +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > +CONFIGURE_ARGS= ${GTK_CONFIG}
> > INSTALL_TARGET= site-install
>
> WRKSRC should be between the DEPENDS and USE sections, IIRC, and
> CONFIGURE_ARGS should be part of the USE section and seperated from
> INSTALL_TARGET by an empty line.
Porter's Handbook doesn't seem to say such things. Which piece of
documents are you referring to?
IMHO, USE_* options above are indications of dependencies, so they
should be put right after *_DEPENDS section.
Likewise, WRKSRC, CONFIGURE_ARGS and INSTALL_TARGET are all
indications of how to build and install the port, thus they should be
put right before the list of target definitions, I think.
But these are no more than just my personal preference, and I'll be
willing to follow the standard if I was against something explicitly
written. :)
--
/
/__ __
/ ) ) ) ) /
Akinori -Aki- MUSHA aka / (_ / ( (__( @ idaemons.org / FreeBSD.org
"We're only at home when we're on the run, on the wing, on the fly"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86itr1dlan.wl>