From nobody Thu Apr 3 19:32:09 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZTBhB1g6vz5sLmr; Thu, 03 Apr 2025 19:32:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZTBh941Cdz3SBY; Thu, 03 Apr 2025 19:32:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743708729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KI1hqC11xUpZMXXXJVuAordSDBhJ6b7aMBly7YS0pMI=; b=P8xQlbmoHmIVODaTxx7imVjtYTEBTf4Y6Fh9Q4VbL9OaO7CTU3q9xBzF6ZkkrSveAIaOOy Ys61g0FgrwPq0NUaZqZ0ZmJPbjCoA9b7KqnbEPEgj5XUzv6h0gtnezRcfoQYM+YyYSmtKN DH8cxTn2quGcGvC7HM/BvbJnj9SVegjUbZ2/lj39LtrVPTpCf5/ygBSeyT2los/KzoLCSy XKasGZVKJUFECO3O+qp2uu0B6v7PIcELAPsrFNcxT+M4lRU3qSCp1LWplgH/bJcN05Xdty swE/+L8fRai3GlbULA2+9P+WmvBjLnxJ0zaJMe1wMePWXCOgGizDkS/vze58vQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743708729; a=rsa-sha256; cv=none; b=U3vQOeMMJJ2jZSitPS9vhPR+YyJd84TPUW3eH14HZ40VMJ3tiOY83a2axDpxfGn8YAWAlb uNZFrDuX8Urx9NsRC3EyW19LvEvbfOvGDZ4lKawWl0dqsFQIX6VxYpA/6kUKpajlgYGpvc lNnHOgmZ7ZYfOMUJH3LpJTCVAgKExctvdCc2UweEM77TPfEzLLxGsBJAJ8D/pyVrnKmMO5 py3AFWL20RtFMIq63iKMzr3fEmYH/WGLjrwbh4E7ZV1QrRt1IebumN90FHGttNSky8o/wT Y15LVpBK6ozfbdCDaXwmAQfZVUy4XGpTyCgbrTjiBjWuFPwmw5HUiPUgSbrypA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743708729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KI1hqC11xUpZMXXXJVuAordSDBhJ6b7aMBly7YS0pMI=; b=QQUHKRIcFrXCoZyCORUALi2Dkopz4sNRT/Mc0A8VzKcR3fMdLb98nwI13N0Gb1TECdAfwI smu3zudiH8BqcG4aiJKLini3bm779mWPd499r2QcE2oJFT43VzUMgu0HG63WEpp2THrWp6 yaI5Fp3SdaJQTMd0NWSq4XSYf3v8p/Tovngojs0GDmiZ2lbKJiqxdIGYCWv7n3lBtOLlqJ Y8RzrXLfPtzaX/ifKEXvNaPAjN56vgNfBmVaZyOHj3oUuLXJ3RSAQL44sBshbIzZVeiYgF H7aLLxTqaNmDtwz9engI7OtHXnuFCciBpAlDcBxpDDiHLpeC5b7+6sCbE619iQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZTBh93d1GzLw; Thu, 03 Apr 2025 19:32:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 533JW9BZ039955; Thu, 3 Apr 2025 19:32:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 533JW9kA039952; Thu, 3 Apr 2025 19:32:09 GMT (envelope-from git) Date: Thu, 3 Apr 2025 19:32:09 GMT Message-Id: <202504031932.533JW9kA039952@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 9b7e21d9187c - stable/14 - MAC/do: Re-order jail methods more logically, rename List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9b7e21d9187cfff32d190fabadee20561afeaba2 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=9b7e21d9187cfff32d190fabadee20561afeaba2 commit 9b7e21d9187cfff32d190fabadee20561afeaba2 Author: Olivier Certner AuthorDate: 2024-07-03 15:00:43 +0000 Commit: Olivier Certner CommitDate: 2025-04-03 19:31:00 +0000 MAC/do: Re-order jail methods more logically, rename No functional change intended. Reviewed by: bapt Approved by: markj (mentor) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47606 (cherry picked from commit 2b2c19b7f697cc88d4da3e8e13051139cd0a4f96) --- sys/security/mac_do/mac_do.c | 87 +++++++++++++++++++++++--------------------- 1 file changed, 45 insertions(+), 42 deletions(-) diff --git a/sys/security/mac_do/mac_do.c b/sys/security/mac_do/mac_do.c index 3327711fa9b9..78c05e9be260 100644 --- a/sys/security/mac_do/mac_do.c +++ b/sys/security/mac_do/mac_do.c @@ -337,40 +337,23 @@ SYSCTL_PROC(_security_mac_do, OID_AUTO, rules, 0, 0, sysctl_rules, "A", "Rules"); -static int -mac_do_prison_set(void *obj, void *data) -{ - struct prison *pr = obj; - struct vfsoptlist *opts = data; - char *rules_string; - int error, jsys, len; - - error = vfs_copyopt(opts, "mdo", &jsys, sizeof(jsys)); - if (error == ENOENT) - jsys = -1; - error = vfs_getopt(opts, "mdo.rules", (void **)&rules_string, &len); - if (error == ENOENT) - rules_string = ""; - else - jsys = JAIL_SYS_NEW; - switch (jsys) { - case JAIL_SYS_INHERIT: - remove_rules(pr); - error = 0; - break; - case JAIL_SYS_NEW: - error = parse_and_set_rules(pr, rules_string); - break; - } - return (error); -} SYSCTL_JAIL_PARAM_SYS_NODE(mdo, CTLFLAG_RW, "Jail MAC/do parameters"); SYSCTL_JAIL_PARAM_STRING(_mdo, rules, CTLFLAG_RW, MAC_RULE_STRING_LEN, "Jail MAC/do rules"); + static int -mac_do_prison_get(void *obj, void *data) +mac_do_jail_create(void *obj, void *data __unused) +{ + struct prison *const pr = obj; + + set_empty_rules(pr); + return (0); +} + +static int +mac_do_jail_get(void *obj, void *data) { struct prison *ppr, *pr = obj; struct vfsoptlist *opts = data; @@ -391,16 +374,7 @@ done: } static int -mac_do_prison_create(void *obj, void *data __unused) -{ - struct prison *const pr = obj; - - set_empty_rules(pr); - return (0); -} - -static int -mac_do_prison_check(void *obj, void *data) +mac_do_jail_check(void *obj, void *data) { struct vfsoptlist *opts = data; char *rules_string; @@ -427,6 +401,34 @@ mac_do_prison_check(void *obj, void *data) return (error); } +static int +mac_do_jail_set(void *obj, void *data) +{ + struct prison *pr = obj; + struct vfsoptlist *opts = data; + char *rules_string; + int error, jsys, len; + + error = vfs_copyopt(opts, "mdo", &jsys, sizeof(jsys)); + if (error == ENOENT) + jsys = -1; + error = vfs_getopt(opts, "mdo.rules", (void **)&rules_string, &len); + if (error == ENOENT) + rules_string = ""; + else + jsys = JAIL_SYS_NEW; + switch (jsys) { + case JAIL_SYS_INHERIT: + remove_rules(pr); + error = 0; + break; + case JAIL_SYS_NEW: + error = parse_and_set_rules(pr, rules_string); + break; + } + return (error); +} + /* * OSD jail methods. * @@ -435,12 +437,13 @@ mac_do_prison_check(void *obj, void *data) * destructor. */ static const osd_method_t osd_methods[PR_MAXMETHOD] = { - [PR_METHOD_CREATE] = mac_do_prison_create, - [PR_METHOD_GET] = mac_do_prison_get, - [PR_METHOD_SET] = mac_do_prison_set, - [PR_METHOD_CHECK] = mac_do_prison_check, + [PR_METHOD_CREATE] = mac_do_jail_create, + [PR_METHOD_GET] = mac_do_jail_get, + [PR_METHOD_CHECK] = mac_do_jail_check, + [PR_METHOD_SET] = mac_do_jail_set, }; + static void init(struct mac_policy_conf *mpc) {