From owner-freebsd-ports Sat May 8 2: 5: 6 1999 Delivered-To: freebsd-ports@freebsd.org Received: from neutron.cichlids.com (as4-053.rp-plus.de [149.221.238.117]) by hub.freebsd.org (Postfix) with SMTP id 1E7EC154B7 for ; Sat, 8 May 1999 02:05:02 -0700 (PDT) (envelope-from alex@cichlids.com) Received: (qmail 899 invoked from network); 8 May 1999 09:14:47 -0000 Received: from cichlids.cichlids.com (192.168.0.10) by neutron.cichlids.com with SMTP; 8 May 1999 09:14:47 -0000 Received: (from alex@localhost) by cichlids.cichlids.com (8.9.3/8.9.3) id LAA03907; Sat, 8 May 1999 11:05:22 +0200 (CEST) (envelope-from alex) From: Alexander Langer Date: Sat, 8 May 1999 11:05:22 +0200 To: ports@freebsd.org Cc: clkao@cirx.org Subject: dagrap-0.3 Port improvement Message-ID: <19990508110522.A3892@cichlids.cichlids.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95i X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Hello! dagrab saves files with names it gets from the cddb servers. Often there are names as "Interpret / Title", so it can't save. I suggest the following patch ( $portsdir/audio/dagrab/patches/patch-ab) that converts '/' into '-' in filenames. I've also mailed the author of dagrab, but the portscollection applies a freebsd patch, so the dagrab.c files are not the same. This is a patch from the freebsd-patched version to my version. Alex --- dagrab.c-without Sat May 8 11:04:52 1999 +++ dagrab.c Sat May 8 11:06:42 1999 @@ -608,7 +608,7 @@ struct Wavefile header; int fd,bytes,i,n,q,space; int bcount, sc, missing, speed = 0, ldp, now; - + char *slashp; if(tnmin || tn>tl->max) return (-1); space = ((tl->starts[tn-tl->min+1]-tl->starts[tn-tl->min]) * CD_FRAMESIZE_RAW) >> opt_mono; @@ -623,6 +623,7 @@ else printf("Dumping track %d: lba%7d to lba%7d (needs %d MB)\n",tn, tl->starts[tn-tl->min],tl->starts[tn-tl->min+1]-1, space>>20); tn-=tl->min; + for(slashp = nam; slashp = strchr(slashp, '/'); slashp++) *slashp = '-'; if ((fd=open(nam,O_TRUNC|O_CREAT|O_WRONLY|O_APPEND))==-1){ fprintf(stderr,"%s: error opening wave file %s\n",progname,nam); exit(1); -- ************** I doubt, therefore I might be. ************** *** Send email to to get PGP-Key *** To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message