Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Dec 2022 16:37:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 268301] x11-toolkits/pangox-compat: fix build with clang 15
Message-ID:  <bug-268301-6497-NSQji8Q1fL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-268301-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-268301-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-gnome (Nobody)
<gnome@FreeBSD.org> for maintainer-feedback:
Bug 268301: x11-toolkits/pangox-compat: fix build with clang 15
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268301



--- Description ---
During an exp-run for llvm 15 (see bug 265425), it turned out that
x11-toolkits/pangox-compat failed to build with clang 15:

  pangox.c:983:15: error: incompatible integer to pointer conversion assign=
ing
to 'PangoFontMetrics *' (aka 'struct _PangoFontMetrics *') from 'int'
[-Wint-conversion]
	metrics =3D pango_font_metrics_new ();
		^ ~~~~~~~~~~~~~~~~~~~~~~~~~
  pangox-fontmap.c:944:9: error: incompatible integer to pointer conversion
initializing 'char *' with an expression of type 'int' [-Wint-conversion]
    char *files_str =3D pango_config_key_get ("PangoX/AliasFiles");
	  ^	      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is because pangox-compat uses two private functions from the main pango
library, which are not declared in the public pango headers.

Fix the errors by adding the two private functions in pango-impl-utils.h,
copying the declarations from pango-font-private.h and pango-utils-private.=
h.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-268301-6497-NSQji8Q1fL>