From owner-freebsd-current  Fri Feb 23 21:38:20 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id AE79937B491
	for <freebsd-current@FreeBSD.ORG>; Fri, 23 Feb 2001 21:38:16 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA32390;
	Sat, 24 Feb 2001 16:38:07 +1100
Date: Sat, 24 Feb 2001 16:29:06 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Daniel Rock <D.Rock@t-online.de>
Cc: Jake Burkholder <jburkholder0829@home.com>,
	freebsd-current@FreeBSD.ORG
Subject: Re: HEADS UP Re: cvs commit: src/sys/alpha/alpha trap.c 
 src/sys/dev/acpica/Osd OsdSchedule.c src/sys/i386/i386 genassym.c  swtch.s
 trap.c src/sys/ia64/ia64 trap.c src/sys/kern init_main.c  kern_condvar.c
 kern_idle.c kern_intr.c kern_mib.c kern_mutex.c  kern_proc.c ...
In-Reply-To: <3A958505.6EBDF1F4@t-online.de>
Message-ID: <Pine.BSF.4.21.0102241610230.26598-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Thu, 22 Feb 2001, Daniel Rock wrote:

> Jake Burkholder schrieb:
> [...]
> > As I mentioned in the commit message, this changes the size and layout
> > of struct kinfo_proc, so you'll have to recompile libkvm-using programs.
> > 
> > As always, make world is your friend.
> 
> You may have forgotten to also change KINFO_PROC_SIZE in src/sys/user.h

Yes, rev.1.31 of src/sys/sys/user.h leaves it as an exercise to change
KINFO_PROC_SIZE.

> 
> I'm now getting bootup warning all the time:
> 
> ...
> real memory  = 197066752 (192448K bytes)
> avail memory = 187293696 (182904K bytes)
> Preloaded elf kernel "kernel" at 0xc0450000.
> WARNING: size of kinfo_proc (648) should be 644!!!

This is normal if you haven't done the exercise.  It is just a warning.

> Pentium Pro MTRR support enabled
> ...
> 
> 
> BTW What is the purpose of KINFO_PROC_SIZE? Why not simply using sizeof()?

It is to inhibit changes in the size of the struct.  Such changes would
break the interface.  The struct must have a certain fixed size (and
layout) for binary compatibility.  sizeof() would give the current size,
not necessarily the size that is required for compatibility.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message