From owner-freebsd-hackers Wed Oct 15 09:00:42 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id JAA27249 for hackers-outgoing; Wed, 15 Oct 1997 09:00:42 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id JAA27240 for ; Wed, 15 Oct 1997 09:00:38 -0700 (PDT) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id IAA13685; Wed, 15 Oct 1997 08:57:47 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd013682; Wed Oct 15 15:57:37 1997 Message-ID: <3444E7A2.41C67EA6@whistle.com> Date: Wed, 15 Oct 1997 08:56:18 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: Darren Reed CC: hackers@FreeBSD.ORG Subject: Re: Freebsd 3.0 current fails ipfilter 3.2b8 build (fwd) References: <199710151233.WAA00595@plum.cyber.com.au> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk All the "_var.h" files contain variables who'se scope is within the kernel only. The only exception is LKMs which should define KERNEL. I don't know who did this, (I see in the logs it was garrett) but the idea is simply to make it more obvios when you are doing the WRONG thing and including kernel private variables (that are subject to change, and not part of the API) . julian Darren Reed wrote: > > Before I commit a change that will fix this absurdity to FreeBSD (i.e. > include if_var.h from if.h), perhaps someone can explain why this > (seemingly needless) change was made. > > Darren > > > On Wed, 15 Oct 1997, Darren Reed wrote: > > > > > In some mail I received from Ron Bolin, sie wrote > > > > > > > > Just thought I'd pass on these errors while trying to build the 32.b8 > > > > ipfilter on FreeBSD 3.0 current 10-11-97. I'd look further, but I don't > > > > have the time right now. > > > [...] > > > > > > sigh...it wasn't always that bad... > > > > > > I wonder if that's due to freebsd header lossage or some other change > > > which I didn't notice ... > > > > > > sigh. > > > > > > > > Yeah, big sigh, struct ifnet was moved into net/if_var.h, for no real > > advantage. I got these problems with 3.0 snap recently. > > Also there is an ifdef in if.h that includes the struct only > > if KERNEL defined.