From owner-freebsd-stable@FreeBSD.ORG Sat Sep 2 04:31:50 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C40616A4DE for ; Sat, 2 Sep 2006 04:31:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7]) by mx1.FreeBSD.org (Postfix) with SMTP id 471FB43D49 for ; Sat, 2 Sep 2006 04:31:49 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 6776 invoked by uid 399); 2 Sep 2006 04:31:48 -0000 Received: from localhost (HELO ?192.168.0.10?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 2 Sep 2006 04:31:48 -0000 Message-ID: <44F9093A.5040001@FreeBSD.org> Date: Fri, 01 Sep 2006 21:31:54 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: freebsd-stable@freebsd.org X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Fwd: cvs commit: src/libexec/save-entropy save-entropy.sh] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Sep 2006 04:31:50 -0000 FYI, I just MFC'ed this change to RELENG_6. I do not plan to MFC it to RELENG_5. I believe this will help avoid the symptoms of the most common user errors that we see complaints about on the mailing list, and my personal mailbox. I tested the changes thoroughly on both HEAD and RELENG_6, so I do not anticipate any problems, but please consider this a mini-heads up. Doug -- This .signature sanitized for your protection -------- Original Message -------- Subject: cvs commit: src/libexec/save-entropy save-entropy.sh Date: Mon, 28 Aug 2006 06:41:50 +0000 (UTC) From: Doug Barton To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org dougb 2006-08-28 06:41:50 UTC FreeBSD src repository Modified files: libexec/save-entropy save-entropy.sh Log: 1. Attempt to take one bullet out of the foot-shooting gun by silently ignoring errors when sourcing rc.conf* files. The most common error occurs when users put a command of some sort into those files. (ifconfig is a popular choice) 2. Make the file rotation logic simpler by starting one down from the "top" of the list, rather than at the top. 3. Try to make file rotation more secure by calling unlink(1) on all new file names before rotating an old file to the new name, rather than merely calling 'rm -f' on any files that exceed the number of files to save. Revision Changes Path 1.4 +10 -10 src/libexec/save-entropy/save-entropy.sh http://www.FreeBSD.org/cgi/cvsweb.cgi/src/libexec/save-entropy/save-entropy.sh.diff?&r1=1.3&r2=1.4&f=h