From owner-svn-src-all@freebsd.org Mon Feb 25 19:10:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E815C1513108; Mon, 25 Feb 2019 19:10:39 +0000 (UTC) (envelope-from luporl@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9010F75017; Mon, 25 Feb 2019 19:10:39 +0000 (UTC) (envelope-from luporl@freebsd.org) Received: from mail-it1-f178.google.com (mail-it1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: luporl/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 0E0B614873; Mon, 25 Feb 2019 19:10:39 +0000 (UTC) (envelope-from luporl@freebsd.org) Received: by mail-it1-f178.google.com with SMTP id l15so75813iti.4; Mon, 25 Feb 2019 11:10:39 -0800 (PST) X-Gm-Message-State: AHQUAuY5PmoW9JNEGFDA9BfWHAjWu2GF/U+rJPY5rT6mFhsXwvHfOdRB Kz6LdMtLCBij9xD/8iMx33a181Da2s7mHWZdZpY= X-Google-Smtp-Source: AHgI3IZWeMxqoZq9QsgDAZZHnYhWny8MNVrKypBeVOWqIQJwNdi2HgaOzEqVBID4Q65FTNRTAA1eyHNiP3eHhFuCVmg= X-Received: by 2002:a02:1b58:: with SMTP id l85mr10543123jad.86.1551121838502; Mon, 25 Feb 2019 11:10:38 -0800 (PST) MIME-Version: 1.0 References: <201902251852.x1PIqlf7034853@repo.freebsd.org> In-Reply-To: From: luporl Date: Mon, 25 Feb 2019 16:10:25 -0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r344534 - head/cddl/contrib/opensolaris/tools/ctf/cvt To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9010F75017 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 19:10:40 -0000 Sorry, I forgot to copy the summary from D19353. Is there a way to change it now? On Mon, Feb 25, 2019 at 3:56 PM Ian Lepore wrote: > > On Mon, 2019-02-25 at 18:52 +0000, Leandro Lupori wrote: > > Author: luporl > > Date: Mon Feb 25 18:52:47 2019 > > New Revision: 344534 > > URL: https://svnweb.freebsd.org/changeset/base/344534 > > > > Log: > > Increase ctfconvert buffer size > > > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D19353 > > > > This is not a very good commit message. To be good, it should say why > the size is being increased. If the commit had included the summary > text from D19353 it would have been perfect. > > -- Ian > > > Modified: > > head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > > > Modified: head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > ===================================================================== > > ========= > > --- head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > > 25 18:41:16 2019 (r344533) > > +++ head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > > 25 18:52:47 2019 (r344534) > > @@ -1268,7 +1268,7 @@ die_funcptr_create(dwarf_t *dw, Dwarf_Die die, > > Dwarf_O > > static intr_t * > > die_base_name_parse(const char *name, char **newp) > > { > > - char buf[100]; > > + char buf[256]; > > char const *base; > > char *c; > > int nlong = 0, nshort = 0, nchar = 0, nint = 0; > > >