From owner-freebsd-questions@FreeBSD.ORG Mon Aug 7 22:30:16 2006 Return-Path: X-Original-To: freebsd-questions@freebsd.org Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8534116A4E0 for ; Mon, 7 Aug 2006 22:30:15 +0000 (UTC) (envelope-from bsam@bsam.ru) Received: from mail.kuban.ru (mail.kuban.ru [62.183.66.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A41143D53 for ; Mon, 7 Aug 2006 22:30:13 +0000 (GMT) (envelope-from bsam@bsam.ru) Received: from bsam.ru ([83.239.48.134]) by mail.kuban.ru (8.9.1/8.9.1) with ESMTP id k77MTpMQ077952; Tue, 8 Aug 2006 02:30:02 +0400 (MSD) Received: from bsam by bsam.ru with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1GADat-0003to-R6; Tue, 08 Aug 2006 02:29:07 +0400 To: Paul Schmehl References: <20060807003815.C7522@ganymede.hub.org> <25528508@bsam.ru> <44D7B71A.6090907@utdallas.edu> From: Boris Samorodov Date: Tue, 08 Aug 2006 02:29:07 +0400 In-Reply-To: <44D7B71A.6090907@utdallas.edu> (Paul Schmehl's message of "Mon, 07 Aug 2006 16:56:42 -0500") Message-ID: <59445996@bsam.ru> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Boris Samorodov Cc: freebsd-questions@freebsd.org Subject: Re: BSDstats Project v2.0 ... X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 22:30:16 -0000 On Mon, 07 Aug 2006 16:56:42 -0500 Paul Schmehl wrote: > Boris Samorodov wrote: > > On Mon, 7 Aug 2006 00:42:27 -0300 (ADT) Marc G. Fournier wrote: > > > >> I've now committed v2.0 of the 300.statistics periodic script ... this > >> one adds the device reporting that we'd talked about previously, and > >> the summary reports now reflect the driver(s) in use for those > >> deciding to report ... > > > > Great, thanks Marc. > > I just propose a tiny patch (the problem was discussed somewhere > > today, may be at ports@): > > ----- > > --- Makefile.orig Tue Aug 8 01:40:57 2006 > > +++ Makefile Tue Aug 8 01:41:16 2006 > > @@ -22,6 +22,6 @@ > > ${MKDIR} ${LOCALBASE}/etc/periodic/monthly > > ${CP} ${FILESDIR}/300.statistics ${LOCALBASE}/etc/periodic/monthly > > post-install: > > - ${CAT} pkg-message > > + ${CAT} ${PKGMESSAGE} > > > Shouldn't that be @${CAT} ${PKGMESSAGE}? Well, I assume that it's more a style change. An "@" may be prepended at all those ${XX} commands. But it's up to author. While the change I propose will work on some non-default settings. And may be the author wants to show an administrator what is installing to the system. WBR -- Boris Samorodov (bsam) Research Engineer, http://www.ipt.ru Telephone & Internet SP FreeBSD committer, http://www.FreeBSD.org The Power To Serve