From owner-svn-src-head@FreeBSD.ORG Tue Oct 16 01:07:20 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C38B2E5D; Tue, 16 Oct 2012 01:07:20 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 99ABE8FC08; Tue, 16 Oct 2012 01:07:20 +0000 (UTC) Received: from epsilon.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 5274B1E319; Mon, 15 Oct 2012 18:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1350349640; bh=4UM/uyxfuaYhne5pMcDBXFqbAr3sTmlqYqbsF3mcb0w=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=lhPvvcw5nOYo3yBJAYNVWff7ePCqxapyLjkQ6REqLu3DkkBbg9zGOzeFuTCat7leq wEj5i7C9caJhxWWZxWo/t+2n8b6OAtv9jI2qqUsqjBFyaPN5wtDRuOJLI/PqJLHfJg vJeEsVAjoN7XGXn4/J+tRcTFNOid4Xnvrb5KSi0M= Message-ID: <507CB347.3040502@delphij.net> Date: Mon, 15 Oct 2012 18:07:19 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r241576 - in head/usr.sbin/cron: cron crontab lib References: <201210150821.q9F8Lobc047576@svn.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Maxim Sobolev , Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2012 01:07:21 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/15/12 17:23, Eitan Adler wrote: > On 15 October 2012 19:26, Adrian Chadd wrote: >> On 15 October 2012 16:10, Eitan Adler >> wrote: >>> On 15 October 2012 18:45, Adrian Chadd >>> wrote: >>>> Why not sleep for the amonut of time needed before the next >>>> event? >>> >>> If the crontab changes in the meantime. If the next event is in >>> a week, but you modify the crontab, you don't want to sleep >>> until next event. >> >> Right. So "check the crontab file" event is also an event with a >> timestamp in the future. >> >> Maybe crontab should be using a command via a socket to reload, >> rather than stat'ing files.. > > "Why we stat the file every quantum instead of using kqueue is a > different question." Because it's not guaranteed to work on every filesystems? But yes I think it would be a good idea to implement it and use it when all filesystems used to store crontabs supports it. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJQfLNHAAoJEG80Jeu8UPuz9bgH/ROQ6e0aAvEQMpRWMNVUYrKq efrqozcXHQU+eK7ceU5f3tX4PSPlMQ3pXGzt02n7sbsblFAnLZPCnJVfesaDBTav Cy9fnfU6dfwCGm7acwVYSAR+s6Wt1nOiKEn/ZNB1QUuvH+XbvdtZ4nAbEjeJzA45 ZBEdj/Dpj2Om3gTBbnmYVMpXeild0OPIFjupfWv0MZvAB2Dp8rOr6qJZXToBH+CZ XHN0ldR6djKVSLWVobY+rqII76pAhhMmgeEeHps8jUPShOtO0jGTqqMf/gk91gb/ cvXGbjqXSU/jBkNJExyCafkyWlocNiGSvYNvnaIT2Xts49WShD0DuScUgr8I+qQ= =1ZYE -----END PGP SIGNATURE-----