From owner-freebsd-current@FreeBSD.ORG Tue May 29 23:00:17 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DEFB316A468 for ; Tue, 29 May 2007 23:00:17 +0000 (UTC) (envelope-from sean-freebsd@farley.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id A9E4D13C480 for ; Tue, 29 May 2007 23:00:17 +0000 (UTC) (envelope-from sean-freebsd@farley.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l4TN0beH031974 for ; Tue, 29 May 2007 18:00:37 -0500 (CDT) (envelope-from sean-freebsd@farley.org) Date: Tue, 29 May 2007 18:00:09 -0500 (CDT) From: "Sean C. Farley" To: freebsd-current@freebsd.org Message-ID: <20070529174352.P98837@thor.farley.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: setenv() patch for POSIX and memory leak X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2007 23:00:18 -0000 I have completed a new version[1] of a replacement (kern/99826[1]) for getenv/setenv/putenv/unsetenv(). A patch against CURRENT that updates libc and a few base utilities can be found here[2]. I built it and ran it successfully. Notes: 1. Fixes memory leak as noted in BUGS section for setenv(3). Example of the leak: setenv("TZ", "CDT", 1); setenv("TZ", "YEKST", 1); // Leaks setenv("TZ", "CDT", 1); setenv("TZ", "YEKST", 1); // Leaks 2. Converts all calls to POSIX from historic BSD API. a. unsetenv returns an int. b. putenv takes a char * instead of const char *. c. errno is set appropriately for POSIX. Exceptions involve bad environ variable and internal initialization code. These both set errno to EFAULT. 3. Several patches to base utilities to handle the POSIX changes are from Andrey Chernov's previous commit. A few I re-wrote to use setenv() instead of putenv(). Yes, I dislike putenv(). :) 4. A new regression module to test these functions was written. It also can be used to test the performance. I found performance to be on-par or better. It is found in tools/regression/environment. 5. Man page could use more work to match all the changes. Thank you to Andrey and others for your help in proofreading several iterations of the code. Sean 1. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/99826 2. http://www.farley.org/freebsd/tmp/setenv/setenv-9/ 3. http://www.farley.org/freebsd/tmp/setenv/setenv-9/setenv.diff -- sean-freebsd@farley.org