Date: Mon, 26 May 1997 19:53:35 +0900 (JST) From: mita@jp.FreeBSD.org To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: ports/3689: pcb-1.4.0 would be better to include documents. Message-ID: <199705261053.TAA00518@datsu.fujita3.iis.u-tokyo.ac.jp> Resent-Message-ID: <199705261100.EAA12011@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 3689
>Category: ports
>Synopsis: port pcb-1.4.0 would be nicer when documents are included.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon May 26 04:00:01 PDT 1997
>Last-Modified:
>Originator: MITA Yoshio
>Organization:
IIS, the University of TOKYO
>Release: FreeBSD 2.2.1-RELEASE i386
>Environment:
>Description:
This patch fixes the problems below:
1. EXTRACT_SUFX is not necessary when extract suffix is .tar.gz .
2. BUILD_DEPENDS target is wrong for this purpose.
RUN_DEPENDS fits for DEPENDENCY for RUNTIME.
3. It is better to install ALL THE DOCUMENTS attached to
the original tarball.
${PREFIX}/share/pcb is recommended as a installation
directory. man1/pcb.1.gz is also necessary.
4. Fix PLIST according to the installation of documents.
5. Remove directory for pcb at the de-installation by @dirrm entry.
I've also sent the same patch to MAINTAINER.
---- >8 snip ----
diff -rcN pcb.orig/Makefile pcb/Makefile
*** pcb.orig/Makefile Sat Nov 16 08:30:59 1996
--- pcb/Makefile Fri May 23 21:18:48 1997
***************
*** 9,20 ****
DISTNAME= pcb-1.4.0
CATEGORIES= cad
MASTER_SITES= ftp://ftp.uni-ulm.de/pub/pcb/1.4/
- EXTRACT_SUFX= .tar.gz
MAINTAINER= janek@gaja.ipan.lublin.pl
! BUILD_DEPENDS= gm4:${PORTSDIR}/devel/m4
USE_IMAKE= yes
.include <bsd.port.mk>
--- 9,24 ----
DISTNAME= pcb-1.4.0
CATEGORIES= cad
MASTER_SITES= ftp://ftp.uni-ulm.de/pub/pcb/1.4/
MAINTAINER= janek@gaja.ipan.lublin.pl
! RUN_DEPENDS= gm4:${PORTSDIR}/devel/m4
USE_IMAKE= yes
+
+ post-install:
+ @mkdir -p ${PREFIX}/share/doc/pcb
+ @${INSTALL_DATA} ${WRKSRC}/doc/* ${PREFIX}/share/doc/pcb/
+ @${INSTALL_DATA} ${WRKSRC}/README_FILES/* ${PREFIX}/share/doc/pcb/
.include <bsd.port.mk>
diff -rcN pcb.orig/pkg/PLIST pcb/pkg/PLIST
*** pcb.orig/pkg/PLIST Mon Mar 25 17:30:53 1996
--- pcb/pkg/PLIST Fri May 23 21:37:56 1997
***************
*** 105,107 ****
--- 105,127 ----
lib/X11/pcb/packages/plcc84.pkg
lib/X11/pcb/packages/to3.pkg
lib/X11/app-defaults/Pcb
+ man/man1/pcb.1.gz
+ share/doc/pcb/pcb.ps.gz
+ share/doc/pcb/refcard.ps.gz
+ share/doc/pcb/texinfo.tex.gz
+ share/doc/pcb/INSTALL
+ share/doc/pcb/LICENSE
+ share/doc/pcb/MAILING
+ share/doc/pcb/README
+ share/doc/pcb/Whats_new_in_1.4
+ @dirrm share/doc/pcb
+ @dirrm lib/X11/pcb/packages
+ @dirrm lib/X11/pcb/circuits/linear
+ @dirrm lib/X11/pcb/circuits/memory
+ @dirrm lib/X11/pcb/circuits/generics
+ @dirrm lib/X11/pcb/circuits/lsi
+ @dirrm lib/X11/pcb/circuits/connectors
+ @dirrm lib/X11/pcb/circuits/discrete
+ @dirrm lib/X11/pcb/circuits/ttl
+ @dirrm lib/X11/pcb/circuits
+ @dirrm lib/X11/pcb
---- >8 snip ----
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705261053.TAA00518>