From owner-cvs-all@FreeBSD.ORG Sun May 28 18:42:57 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4F8416A6B3; Sun, 28 May 2006 18:42:57 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7482643D46; Sun, 28 May 2006 18:42:57 +0000 (GMT) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4SIflYu080875; Sun, 28 May 2006 18:41:47 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4SIfl3Q080874; Sun, 28 May 2006 18:41:47 GMT (envelope-from silby) Message-Id: <200605281841.k4SIfl3Q080874@repoman.freebsd.org> From: Mike Silbersack Date: Sun, 28 May 2006 18:41:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/bfe if_bfe.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 May 2006 18:43:04 -0000 silby 2006-05-28 18:41:47 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c Log: 1. Make sure that the TX and RX descriptor rings are 4096 byte aligned. Also use BUS_DMA_ALLOCNOW to be on the safe side. 2. Look for the Descriptor Error, and Descriptor Protocol Error flags from the card, and down the interface if we detect either. #1 (along with fixes to busdma) makes sure that this card works in all memory situations. Prior to this change, it was just luck that 512 count RX/TX lists were properly aligned. Now we can use any size of RX/TX lists and still have them properly aligned. #2 ensures that we don't get into an endless interrupt storm if busdma fails us. Descriptor Protocol Error would occur if we misaligned the TX/RX rings, and Descriptor Error would occur if we tried to give the card descriptors or rings with addresses > 1G. Trying to reinitialize the card isn't going to fix these errors, hence we don't try. Revision Changes Path 1.39 +21 -6 src/sys/dev/bfe/if_bfe.c