Date: Fri, 20 Mar 2015 09:28:59 -0600 From: Warner Losh <imp@bsdimp.com> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, HardenedBSD Core <core@hardenedbsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: ASLR work into -HEAD ? Message-ID: <CC2C8923-A3EB-4EE4-9DBB-A2CC444902BF@bsdimp.com> In-Reply-To: <CAPQ4fftmjJ2tfAWzULoTQiY3ZO=GRP9VRt-LtzxUnoMJCZgHLw@mail.gmail.com> References: <CAJ-VmomszKm47aLnGWiouUQHvmB8%2BchA=y-q1zvtOwJ7_iqe0g@mail.gmail.com> <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> <CAJ-Vmo=JZoM0V=sSNtW-2Pdh-8gtXWhAGd7uKV7v_rwECqMQJw@mail.gmail.com> <CAPQ4fftmjJ2tfAWzULoTQiY3ZO=GRP9VRt-LtzxUnoMJCZgHLw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 19, 2015, at 2:31 PM, Oliver Pinter = <oliver.pinter@hardenedbsd.org> wrote: >=20 > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd <adrian@freebsd.org> = wrote: >> On 19 March 2015 at 12:56, Warner Losh <imp@bsdimp.com> wrote: >>>=20 >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd <adrian@freebsd.org> = wrote: >>>>=20 >>>> Hi, >>>>=20 >>>> Apparently this is done but has stalled: >>>>=20 >>>> https://reviews.freebsd.org/D473 >>>>=20 >>>> Does anyone have any strong objections to it landing in the tree = as-is? >>>=20 >>> There=E2=80=99s rather a lot of them specifically spelled out in the = code review. >>>=20 >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not = been inclined >>> to take the time to re-review it. Glancing at it, I see several = minor issues >>> that should be cleaned up. >>=20 >> Cool. Thanks for taking the time to look at it again. >>=20 >> Shawn is in #freebsd on freenode irc, so if you/others want a more >> interactive review then he's there during the day. >=20 > Please CC the core@hardenedbsd.org in future please, when you are > talking about this issue. >=20 > Adrian: do you able to review the MIPS or ARM part especially or test = them? Adrian: Do not commit the changes. I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather long = review and it appears that virtually none of that has been addressed. Until it is, do not = commit it. This code interacts with dangerous parts of the system, and the default = cannot be to just let it in because no one has objected recently. Objections have = been made, they have been quantified, they haven=E2=80=99t been answered or acted = upon. Until that changes, you can assume the objections remain in place and asking again = without fixing them isn=E2=80=99t going to change the answer. Warner --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDDy7AAoJEGwc0Sh9sBEAteUP+wRwNQxW6HO25JahREu0H7tr d5FVhWHqPRvpzNFHZsg4r4PRBkVdePoHoUDBhm8WHwKLOWsEN2349fZqn5V4XCfp J7ER5k7YQg8pToCHC15j7L6swTN1BWx+SwPPStiozvlqPfLM3IQm62UBjNpR+Por Lx/DVc8fdd5JmO8lMZ3G7GmgL5k9f3MsmnPhrpwe8E0a5qMJ2Yv9jDXZmP4wcuRA 9b6H10iY1QvX5kP/QMjqPcbxY3M9d03JXWQOnlrOr9DcYSWmebFaQvtqugmKViV5 iCBWbuHVowrUamQ6ZA74xO/4cN1cBkRe4GF2UEy+a8xkIhEUp/MpFtQtQwfJLtsN HllMtIzDRNLfcZE372gc5T8PnqBKeLsDtgdlkqy8XLA213pHxWeP81v3GjlYY5dS jABuNtVUuiIwsM6r0CMEbMGJqVokTmzOA7bzIB93b+qw/2T/1eEr0gRnC27idoPy k0EydEFitDWAOjTYSDKA4I1G7vz6NSyDT/9W3Ngv+VDOme4xm+qTUBpVTeQMFoN+ Npr0yl06tM8Bt7an+hNYnB2vg28T/hJpU/6SrwiQCF++OR8eBlyRBUTtMG2WRdy8 KEUu3mVNGF4AB7TiIxEEGxlflEOF3MWNq7FYL6xMvJgGVn8PZaavVsLQfYTAQSmx /vp9K10avrnmgecEoz60 =tWKJ -----END PGP SIGNATURE----- --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CC2C8923-A3EB-4EE4-9DBB-A2CC444902BF>