From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 15:34:19 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A4D1F87 for ; Fri, 20 Mar 2015 15:34:19 +0000 (UTC) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04382CC6 for ; Fri, 20 Mar 2015 15:34:18 +0000 (UTC) Received: by pagj4 with SMTP id j4so21028087pag.2 for ; Fri, 20 Mar 2015 08:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=k9LL/xmAkE1PKHuJTv9UJ3RFkyns4M0J6xjIL1u+LYc=; b=dm6JDiQHSTbo4zlerNfODz+WFY2jGnEmF6/TtrtsrVqPQlbxLdjpJ8MsecvCC6LOJR zcyWAlGiTv61VeOrLUxQl0asuCVhFU8m00h0Arz/FEiEpuNmkwfva129T4cVdcGOSc7a JPufPJMUPenN6xCQhUYWfDxAIo2MkOtLNNnGXNaKaZUzaGUuZjvcyUZYYSAAUuAO0mB4 rNiTBUcF3dJhbDCqOrl1Bq5nNu3S69uHOJz3XzylwrJRbU0zRXp38+uSj5RNHpLNea5A LwJUx5kEQtxVar9wYXlKhOf7D/SncHHwHNilZLwnQXA5Ym70Zj1xujrHsSSQDT1TjeWT 8tuQ== X-Gm-Message-State: ALoCoQmZBF6JmkpZp2YmCUhLO1duz9Sf2npZwwgu1FWyDl01xkydPGmIaUw6DWPDMn4eAZHdqaKz X-Received: by 10.70.51.197 with SMTP id m5mr188975962pdo.90.1426865346742; Fri, 20 Mar 2015 08:29:06 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id fu14sm8710195pad.44.2015.03.20.08.29.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Mar 2015 08:29:05 -0700 (PDT) Sender: Warner Losh Subject: Re: ASLR work into -HEAD ? Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Fri, 20 Mar 2015 09:28:59 -0600 Message-Id: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> To: Oliver Pinter X-Mailer: Apple Mail (2.2070.6) Cc: Adrian Chadd , HardenedBSD Core , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 15:34:19 -0000 --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 19, 2015, at 2:31 PM, Oliver Pinter = wrote: >=20 > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd = wrote: >> On 19 March 2015 at 12:56, Warner Losh wrote: >>>=20 >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd = wrote: >>>>=20 >>>> Hi, >>>>=20 >>>> Apparently this is done but has stalled: >>>>=20 >>>> https://reviews.freebsd.org/D473 >>>>=20 >>>> Does anyone have any strong objections to it landing in the tree = as-is? >>>=20 >>> There=E2=80=99s rather a lot of them specifically spelled out in the = code review. >>>=20 >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not = been inclined >>> to take the time to re-review it. Glancing at it, I see several = minor issues >>> that should be cleaned up. >>=20 >> Cool. Thanks for taking the time to look at it again. >>=20 >> Shawn is in #freebsd on freenode irc, so if you/others want a more >> interactive review then he's there during the day. >=20 > Please CC the core@hardenedbsd.org in future please, when you are > talking about this issue. >=20 > Adrian: do you able to review the MIPS or ARM part especially or test = them? Adrian: Do not commit the changes. I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather long = review and it appears that virtually none of that has been addressed. Until it is, do not = commit it. This code interacts with dangerous parts of the system, and the default = cannot be to just let it in because no one has objected recently. Objections have = been made, they have been quantified, they haven=E2=80=99t been answered or acted = upon. Until that changes, you can assume the objections remain in place and asking again = without fixing them isn=E2=80=99t going to change the answer. Warner --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDDy7AAoJEGwc0Sh9sBEAteUP+wRwNQxW6HO25JahREu0H7tr d5FVhWHqPRvpzNFHZsg4r4PRBkVdePoHoUDBhm8WHwKLOWsEN2349fZqn5V4XCfp J7ER5k7YQg8pToCHC15j7L6swTN1BWx+SwPPStiozvlqPfLM3IQm62UBjNpR+Por Lx/DVc8fdd5JmO8lMZ3G7GmgL5k9f3MsmnPhrpwe8E0a5qMJ2Yv9jDXZmP4wcuRA 9b6H10iY1QvX5kP/QMjqPcbxY3M9d03JXWQOnlrOr9DcYSWmebFaQvtqugmKViV5 iCBWbuHVowrUamQ6ZA74xO/4cN1cBkRe4GF2UEy+a8xkIhEUp/MpFtQtQwfJLtsN HllMtIzDRNLfcZE372gc5T8PnqBKeLsDtgdlkqy8XLA213pHxWeP81v3GjlYY5dS jABuNtVUuiIwsM6r0CMEbMGJqVokTmzOA7bzIB93b+qw/2T/1eEr0gRnC27idoPy k0EydEFitDWAOjTYSDKA4I1G7vz6NSyDT/9W3Ngv+VDOme4xm+qTUBpVTeQMFoN+ Npr0yl06tM8Bt7an+hNYnB2vg28T/hJpU/6SrwiQCF++OR8eBlyRBUTtMG2WRdy8 KEUu3mVNGF4AB7TiIxEEGxlflEOF3MWNq7FYL6xMvJgGVn8PZaavVsLQfYTAQSmx /vp9K10avrnmgecEoz60 =tWKJ -----END PGP SIGNATURE----- --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1--