From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 30 05:20:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4823D16A421 for ; Sun, 30 Sep 2007 05:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 359D513C45A for ; Sun, 30 Sep 2007 05:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8U5K225043298 for ; Sun, 30 Sep 2007 05:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8U5K1DJ043297; Sun, 30 Sep 2007 05:20:01 GMT (envelope-from gnats) Resent-Date: Sun, 30 Sep 2007 05:20:01 GMT Resent-Message-Id: <200709300520.l8U5K1DJ043297@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Josh Carroll Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8F2E16A418 for ; Sun, 30 Sep 2007 05:17:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D55CF13C467 for ; Sun, 30 Sep 2007 05:17:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l8U5HlO5008250 for ; Sun, 30 Sep 2007 05:17:47 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id l8U5HloV008249; Sun, 30 Sep 2007 05:17:47 GMT (envelope-from nobody) Message-Id: <200709300517.l8U5HloV008249@www.freebsd.org> Date: Sun, 30 Sep 2007 05:17:47 GMT From: Josh Carroll To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/116757: ushare is broken for amd64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 05:20:02 -0000 >Number: 116757 >Category: ports >Synopsis: ushare is broken for amd64 >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 30 05:20:01 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Josh Carroll >Release: 6.2-RELEASE-p7 amd64 >Organization: n/a >Environment: FreeBSD pflog.net 6.2-RELEASE-p7 FreeBSD 6.2-RELEASE-p7 #0: Sat Sep 29 14:50:41 EDT 2007 root@pflog.net:/usr/obj/usr/src/sys/PFLOG64 amd64 >Description: The ushare port has a bug in the code that prevents it from working properly on an amd64 installation of 6.2-RELEASE. When ushare is run, it fails with: pflog# /usr/local/etc/rc.d/ushare start Starting ushare. sysctl: No such file or directory I tracked this down to the sysctl calls in ushare.c, which are passing &len with len defined as an int. In fact, the compiler generates warnings for these: ushare.c: In function `create_udn': ushare.c:413: warning: passing arg 4 of `sysctl' from incompatible pointer type ushare.c:420: warning: passing arg 4 of `sysctl' from incompatible pointer type len should be of type size_t, not int. Defining len as size_t fixes the problem. Thanks, Josh >How-To-Repeat: cd /usr/ports/net/ushare make && make install /usr/local/etc/rc.d/ushare forcestart >Fix: Attached is a patch which changes the type of len from int to size_t in the create_udn function. Patch attached with submission follows: --- src/ushare.c.old Sun Sep 30 01:03:37 2007 +++ src/ushare.c Sun Sep 30 01:03:57 2007 @@ -386,7 +386,8 @@ unsigned char *ptr; #if (defined(BSD) || defined(__FreeBSD__)) - int mib[6], len; + int mib[6]; + size_t len; struct if_msghdr *ifm; struct sockaddr_dl *sdl; #else /* Linux */ >Release-Note: >Audit-Trail: >Unformatted: