From owner-svn-src-head@freebsd.org Mon Jun 29 17:47:52 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E0FE350146 for ; Mon, 29 Jun 2020 17:47:52 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49wZhR3tWRz47xN for ; Mon, 29 Jun 2020 17:47:51 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x841.google.com with SMTP id v19so13468475qtq.10 for ; Mon, 29 Jun 2020 10:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H3UE1CsSLolUF//MIGaKxVN18uJC60taaK6CQOj7gpc=; b=UEbZkps+h6WY2bmt7d87tOsx9DutIF+Aj4qc1FuYqPZprNlc0ZJUNou+8RCj0k4wA7 dWtFwA38sbBE7PhuH8CYvYpHNuh/j2fCNaCnvo41Z2SbqT2aXlGqIQ1ECR2qxaY4ck0q 2dyQJ97jnUcf0YVZ04soBadkSJ+uNxzujlf1J2ANINldp7+mw7Vb72w19HpcpsXfRsLy 6rKicPyUiyA7IzsA1uKVwPulHlO+3lpA5zahyEJ+zm4Zcr8UZk7uoAgTR0XVOm5YIOKY DHTPGZgpb0S50qbTixhCB362pBazXb5UmYkiIO2f/DDlGmU+mo8U6la71+OIROAsLr/A md8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H3UE1CsSLolUF//MIGaKxVN18uJC60taaK6CQOj7gpc=; b=TIKMG+LTLhB1suwNL/ARwTiJrsqTlaq2to8k5z+7WU3Yb2RRD9R8ZeTupCRiwseBXa JJyBqpJlf8yNUzOEZokbIapqMzU5OoWpFl9cB2b0PnyidauHyxfPvncDs53f+ti/C0Al 0yL6L9tYGpnB+Hs+WTZ+ryXV1miudQmTVytSDS3yLWJkZUmgj3RMBgAa2TZTkTQliyt0 guaW2Zfqf2VAs5Kj3tYrvJz0pBsyM/btjC5fut059qfrYmWxsJ8CBUOkE7N6ms6JTfRD Ilmxc+eEW8+MchrrGHw5a+SjSdX/sbbc+o2DCjIvAhX1rVIMxzy/JOkFXZ5T0lUxkRzL 4qEg== X-Gm-Message-State: AOAM531+zozX7A6IuwKFQoGZ5WR3F9dJ/syQYdWHUgEkzqcIjekElxE0 82qXMTsSXj4OhfROUPO2qbsMOQ== X-Google-Smtp-Source: ABdhPJzhKyI2MISBRB2VjTI8iv2CLxNjkffI3fbh0vAy07eK2MVkBFniqKgmBJWTZb3hJPFtQxYbnw== X-Received: by 2002:ac8:3981:: with SMTP id v1mr16848003qte.134.1593452870667; Mon, 29 Jun 2020 10:47:50 -0700 (PDT) Received: from mutt-hbsd (75-148-2-186-WashingtonDC.hfc.comcastbusiness.net. [75.148.2.186]) by smtp.gmail.com with ESMTPSA id j7sm388752qtd.53.2020.06.29.10.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 10:47:50 -0700 (PDT) Date: Mon, 29 Jun 2020 13:47:28 -0400 From: Shawn Webb To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head , Edward Tomasz Napiera??a Subject: Re: svn commit: r362769 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/linux i386/linux Message-ID: <20200629174728.ln77pjbg65v3kxwf@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA References: <202006290309.05T39ETZ044859@repo.freebsd.org> <20200629152717.2ojwnipxkmjaoix2@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2b2d3wgxtc4uresf" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 49wZhR3tWRz47xN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=UEbZkps+; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::841 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-4.22 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-1.03)[-1.030]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-0.99)[-0.994]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-0.10)[-0.095]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::841:from]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 17:47:52 -0000 --2b2d3wgxtc4uresf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2020 at 12:42:49PM -0500, Kyle Evans wrote: > On Mon, Jun 29, 2020 at 10:27 AM Shawn Webb = wrote: > > > > Hey Kyle, > > > > On Mon, Jun 29, 2020 at 03:09:14AM +0000, Kyle Evans wrote: > > > Author: kevans > > > Date: Mon Jun 29 03:09:14 2020 > > > New Revision: 362769 > > > URL: https://svnweb.freebsd.org/changeset/base/362769 > > > > > > Log: > > > linuxolator: implement memfd_create syscall > > > > > > This effectively mirrors our libc implementation, but with minor fu= dging -- > > > name needs to be copied in from userspace, so we just copy it strai= ght into > > > stack-allocated memfd_name into the correct position rather than al= locating > > > memory that needs to be cleaned up. > > > > > > The sealing-related fcntl(2) commands, F_GET_SEALS and F_ADD_SEALS,= have > > > also been implemented now that we support them. > > > > > > Note that this implementation is still not quite at feature parity = w.r.t. > > > the actual Linux version; some caveats, from my foggy memory: > > > > > > - Need to implement SHM_GROW_ON_WRITE, default for memfd (in progre= ss) > > > - LTP wants the memfd name exposed to fdescfs > > > - Linux allows open() of an fdescfs fd with O_TRUNC to truncate aft= er dup. > > > (?) > > > > > > Interested parties can install and run LTP from ports (devel/linux-= ltp) to > > > confirm any fixes. > > > > > > PR: 240874 > > > Reviewed by: kib, trasz > > > Differential Revision: https://reviews.freebsd.org/D21845 > > > > RELNOTES? > > > > > > > > Modified: > > > head/sys/amd64/linux/linux_dummy.c > > > head/sys/amd64/linux32/linux32_dummy.c > > > head/sys/arm64/linux/linux_dummy.c > > > head/sys/compat/linux/linux.c > > > head/sys/compat/linux/linux.h > > > head/sys/compat/linux/linux_file.c > > > head/sys/compat/linux/linux_file.h > > > head/sys/i386/linux/linux_dummy.c > > > > Should __FreeBSD_version be bumped? > > >=20 > I'm roping in trasz@, because I'm unsure on either of these points -- > I haven't paid attention and don't know if we typically include linux > syscalls that we implement in relnotes, and given that this commit > only really affects pre-compiled Linux binaries I'm not sure if > there's any utility in bumping __FreeBSD_version; presumably ports > folks can't do anything differently here, and binaries will work just > the same. Hey Kyle, I assumed as much, but I wasn't entirely sure. I thought I'd just ask anyways. Thanks for the clarification. :) --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --2b2d3wgxtc4uresf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl76KSsACgkQ/y5nonf4 4foVHw/+M7P2PtbrYgTpYcuieXRoHk0M3V8OUFP9v5l/Eof94f+sSvBQqzF5279j 045OkhvaXNeCKpXUxOAy/D0HXQQWNMB4JenMAQHkVEJ/fAnnXmFdtMgzUjEZHPB2 Ka3SyByuwCBarZFQymDpquLFsU8N6IG+yHYPmedXhQnYBchAlHr7oMUfoDLiwF8X SCJCASu5hrKwv1XMWa7HB9xTAmUiG4Qo2Lc8PAQaNVcIWQJJraDJIoI7PylfDi1M mMoVulM90P8GbpkiuxASr9459O5kCk0cVmfvZrtCC0Mc8PwnuF6WLBiSIP9rJMAz I8gDhXTCU62Ds88r7B0JXE+5DzZvTyDKdLDgqTc3+EtzAbIDzy+Tu818XfnBMvAI PrjuTvOdeZBbX09yT+ECKZYlwvJZDdQ5jT2fZbQUH+lVaw66dPNwJrjHJ8IRc9mr IW/ZwFTnqqBSNeOBx2ll/YxEnmG193RuZ9Ikv+d/Ku5LYW7uMOI1vorWnOo+HqFz RUflmxi4N2Iuswq7IRmif9/U4p7L43PjZsPIGguSOop+V6XSj2FaomEDgtV/PoJw 4rJVQRTnYsgmbw3EfkgOMp9ir+jrLwcdnxVRKEbpMokwhL4dpo9Uo6d5V2hyoqHb EiyS7mmQDibV1d87MHxmZPyuTS4+aCKHZ2q+hYg4WU2uVc0XD1U= =dOHS -----END PGP SIGNATURE----- --2b2d3wgxtc4uresf--