From owner-freebsd-current@freebsd.org Tue Aug 21 14:18:58 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DDFD1074069 for ; Tue, 21 Aug 2018 14:18:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A245A85BB3 for ; Tue, 21 Aug 2018 14:18:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22d.google.com with SMTP id w11-v6so15538510iob.2 for ; Tue, 21 Aug 2018 07:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=njtrCFOVWs9FLAxRm2lSsJ58AK9ALY5Sz3fXfvMy6cI=; b=vlH542LPRd747g+RQLTzfAp4xgnaCWV2TyxJfVE6GZbuyVto9mOzAOJPGMIgeoGNMy 2tPsXWWFDXFj10QzyR2HWdn2C5zOddGTMRu3BXwjaxZxACXe9JxICbjegbNmQ90KmEfN fq/lcCWMwGFm28fjsxoWI7Rg+vnJ+X5vN5lKvB1yuKuinhat7XeRTWrKTk1UWuGLX62o tGYF++bbD19cIHm/oYnnenlQcrJWr4ILP9cQ6+pG7PiE3N18VFs4UxOHjZ9B9wZsZOcO lVYF0k4i0iKuHMbgY3pcmRKInCtZZJietF8yP3pjx4x4z+JmxxWzaPJAZO3tqEEpPA48 rSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=njtrCFOVWs9FLAxRm2lSsJ58AK9ALY5Sz3fXfvMy6cI=; b=c4sY9SVMLICUsl1J+9z/qTYt8NF26U2ouDKomW3BPsRWREk5QNRd/9cCth+LWLPT6R WB/2qtrzhG9d87Z51oVQk/6oiykNb+zdZPlcpeFX6p1FxmTCRBdLEYXWFEgqY3cIYo+V 7lDc80g4Xi2Jf8BpvKebVPKuFeE+1WcOvlYlfk91W8EM+MdgoFJxNUl5GNqo9gXYfvx+ n7NmfMGlNMyCp0FX19zfrGzpKvW3mVC7/eX1j2D+y81wdsdN/dCi1hICBrPITANgvkeT EBxheEiAeQ4/mXS+hFE2SeaE+a1godQVYtO1uPLgh2pDrqQsLg3faOERRmCl17m34lap liFA== X-Gm-Message-State: AOUpUlGei6YLQ+6V3e7L0AWL5x9aolHNglWMfogSz9XW6PIMeEAhY+qb DfOp9VVmGywo4/+bZ45u0EC9KKENzIGtkeiUl49biw== X-Google-Smtp-Source: AA+uWPzuDjWbKN50ooemC56BzsQDapi6mW1Q/JFiNwbq2KTyQeLE7AS26APGJuJk+1Wv2lkYSbQmfXBODpQhTlcRZjM= X-Received: by 2002:a6b:7117:: with SMTP id q23-v6mr26262199iog.37.1534861136940; Tue, 21 Aug 2018 07:18:56 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:2806:0:0:0:0:0 with HTTP; Tue, 21 Aug 2018 07:18:56 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <20180820212448.571e1060@thor.intern.walstatt.dynvpn.de> <20180820220103.3ac8a3ac@thor.intern.walstatt.dynvpn.de> <6040ed15-143f-9a6d-8f37-b25a7e2d2036@FreeBSD.org> From: Warner Losh Date: Tue, 21 Aug 2018 08:18:56 -0600 X-Google-Sender-Auth: I8xKhDjDuYNur5A3FNBhIG88XgI Message-ID: Subject: Re: buildworld failure: Do not include ${SRCTOP}/sys when building bootstrap tools To: Alexander Richardson Cc: John Baldwin , "O. Hartmann" , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 14:18:58 -0000 On Tue, Aug 21, 2018 at 8:16 AM, Warner Losh wrote: > There's a half a dozen special targets, however. clean comes to mind... > > > However, this test is needlessly restrictive: > > .if !empty(CFLAGS:M*${SRCTOP}/sys*:N*${SRCTOP}/sys/cddl/compat*: > N*${SRCTOP}/sys/crypto*) > > since it matches > > CFLAGS+=-I${SRCTOP}/sys/sys/disk > > which is totally legit. It's designed to be legit everywhere for building > on Linux... > > .if !empty(CFLAGS:M*${SRCTOP}/sys:N*${SRCTOP}/sys/cddl/compat:N* > ${SRCTOP}/sys/crypto) > > would be a better test, imho. > Although, I could passively agressively work around it with CFLAGS+=-I${.CURDIR}/../../sys/sys/disk which also kinda defeats its purpose... Warner > Warner > > On Tue, Aug 21, 2018 at 8:11 AM, Alexander Richardson < > arichardson@freebsd.org> wrote: > >> In my testing 338129 fixed the issue. Seems like the problem is that >> bsd.crunchgen.mk iterates over all directories to do a make obj when >> it does the bootstrap-tools phase. >> On Tue, 21 Aug 2018 at 14:49, Warner Losh wrote: >> > >> > >> > >> > On Tue, Aug 21, 2018 at 12:38 AM, John Baldwin wrote: >> >> >> >> On 8/20/18 9:00 PM, O. Hartmann wrote: >> >> > -----BEGIN PGP SIGNED MESSAGE----- >> >> > Hash: SHA512 >> >> > >> >> > Am Mon, 20 Aug 2018 21:24:21 +0200 >> >> > "O. Hartmann" schrieb: >> >> > >> >> >> -----BEGIN PGP SIGNED MESSAGE----- >> >> >> Hash: SHA512 >> >> >> >> >> >> Building NanoBSD world on CURRENT r338113 fails due to: >> >> >> >> >> >> [...] >> >> >> cd /pool/sources/CURRENT/src/rescue/rescue/../../sbin/gbde && >> MK_TESTS=no >> >> >> UPDATE_DEPENDFILE=no _RECURSING_CRUNCH=1 >> >> >> MAKEOBJDIRPREFIX=/pool/nanobsd/amd64/ALERICH_amd64/pool/ >> sources/CURRENT/src/amd64.amd64/rescue/rescue >> >> >> make MK_AUTO_OBJ=no DIRPRFX=rescue/rescue/gbde/ -DRESCUE >> CRUNCH_CFLAGS=-DRESCUE >> >> >> MK_AUTO_OBJ=no obj make[5]: "/pool/sources/CURRENT/src/too >> ls/build/mk/Makefile.boot" >> >> >> line 18: Do not include ${SRCTOP}/sys when building bootstrap >> tools. Copy the header to >> >> >> ${WORLDTMP}/legacy in tools/build/Makefile instead. Error was >> caused by Makefile >> >> >> in /pool/sources/CURRENT/src/sbin/gbde *** [obj_crunchdir_gbde] >> Error code 1 >> >> >> >> >> >> make[4]: stopped in /pool/sources/CURRENT/src/rescue/rescue >> >> >> [...] >> >> >> >> >> >> >> >> >> This problem occured during today's source updates since I was able >> to build the NanoBSD >> >> >> image I intend to build yesterday ~ r338060. >> >> >> >> >> >> What is going wrong? >> >> > >> >> > It seems the problem has been introduced after r338095, since >> r338095 builds ok, while >> >> > r338096 doesn't. >> >> >> >> 338096 added this check to catch a kind of error in our Makefiles. >> Alex (cc'd) can >> >> help with figuring out what the error is. >> > >> > >> > Except we're not building anything, we're making obj in rescue... It >> looks like a false positive... >> > >> > Warner >> > >