From owner-freebsd-current Thu Jun 27 15:32:49 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA02540 for current-outgoing; Thu, 27 Jun 1996 15:32:49 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id PAA02534 for ; Thu, 27 Jun 1996 15:32:46 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with ESMTP id PAA07241; Thu, 27 Jun 1996 15:31:49 -0700 (PDT) To: Nate Williams cc: Scott Blachowicz , current@freebsd.org Subject: Re: Building inside of /usr/src? In-reply-to: Your message of "Thu, 27 Jun 1996 16:10:13 MDT." <199606272210.QAA11833@rocky.mt.sri.com> Date: Thu, 27 Jun 1996 15:31:49 -0700 Message-ID: <7235.835914709@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > Well, you already took it out, so I guess comments don't matter, but > there's *probably* a reason for doing it. You're best bet would be to > remove it *locally* and then test the change to see if bad things happen > before spamming the repository making us find all the bugs. :( I did test it and I carefully followed the logic of the code before making the commit (that's why the commit followed so quickly - it became very quickly clear that this behavior was now a bug in the new system). There's absolutely *no* reason to ignore the output of getcwd() and it does check the directory returned for errors / permission problems. The only thing I can figure out was that someone found AMD's path mangling to be non-intuitive (though functional) or something and figured they'd substitite in the value of $PWD. I can think of no other reason for it and, in fact, it could easily be argued that they weren't thinking straight when they made this change as it makes it far too easy to confuse the bejeezus out of make by using a bogus shell or setting the value of PWD yourself. Jordan