From owner-svn-src-head@freebsd.org Tue Jun 18 18:55:14 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEA1015C56DC for ; Tue, 18 Jun 2019 18:55:14 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18A8289A09 for ; Tue, 18 Jun 2019 18:55:14 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x844.google.com with SMTP id x47so16676132qtk.11 for ; Tue, 18 Jun 2019 11:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X3HfnDoBEh8QwWSdoImCn+gsl4L6L32DUHWE+oJgH8g=; b=ZUTIVm4i654r+2z/ZSiS7xZnNs5wEvKzTHbe//CHUkcES3Lknf6mhIvzQAKPPaHUP3 Z/KBclvJWxEymm854iIK3Z7YntprBXcAd7xz6rDgNlsO2zQXw/z+a8oc9FYXNjnttFAG qL//YQ8fbQ2qtG9sG6QLx5fHdRNqI7sRxw7RM9kFOJlQSHz0FGR5JLeyQqPOdIjShG6f F7s4iNR6ndt/z5TJLPUtd2IRmJ5b2pJyjZmNyTXpqtonGj9Xiyx6JQYSQtEz0AhqlfW6 sSAtlLl05GOWO2Ikhi6J+XJy2R8aBp8RPtbkY3oKJ9sZiLhZnHK/l+MmV6IwUb/KSGva K8vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X3HfnDoBEh8QwWSdoImCn+gsl4L6L32DUHWE+oJgH8g=; b=ohEZg6BD0/0unCBmxk215PEMAKAkELfy3UboTUBxEStsrrMjMLdQvaaF6Stx1nXbvY MhScgzCayF1WCm2GONRHCBMByyqMKYBz+B4ciNN+EuRWTaA/PLXQpa198SoQBR/G2mZL kbM4l8kqr4l9WVfHwxidlb6C387xyhcgaP8ergFk9Hr6f8ICP/5aDp3dY3mkCVsUXlDt YLAJK3VrSZFoP0agWTlDkQmw8W6YuuuQA7PNQO5fxSSBiAoDbLPyIi80SP0qcdEcnelQ lzweLcOxstIYGycRrJ+QKki2p3hVwIBn9GTJdPVEDeQ1A7A4nPVSJJx6O8BsdQod2cJk 8e/w== X-Gm-Message-State: APjAAAUkyycsM6pt4/pBCPWIzeZXL7W36WN7j8Ui/01qSD4KSx2ereIn 4DqpC1lOncHEon8JuN/zg9C4zg== X-Google-Smtp-Source: APXvYqylsgQ99Fc5AU5nXpC9T3AkaFtG55Rs2sRUoR+4DpwTPcK4BQBQDAREnuwdLOh2xmxrTBgpgw== X-Received: by 2002:a0c:d610:: with SMTP id c16mr29445671qvj.22.1560884113553; Tue, 18 Jun 2019 11:55:13 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id e52sm4602483qtk.20.2019.06.18.11.55.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 11:55:12 -0700 (PDT) Date: Tue, 18 Jun 2019 14:55:12 -0400 From: Shawn Webb To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349176 - head/sys/dev/random Message-ID: <20190618185512.e2nbzwbtvxz2azge@mutt-hbsd> References: <201906181850.x5IIow3d020755@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mmc352mzirnzscxj" Content-Disposition: inline In-Reply-To: <201906181850.x5IIow3d020755@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD HARDENEDBSD-13-CURRENT amd64 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 18A8289A09 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.974,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 18:55:15 -0000 --mmc352mzirnzscxj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 18, 2019 at 06:50:58PM +0000, Conrad Meyer wrote: > Author: cem > Date: Tue Jun 18 18:50:58 2019 > New Revision: 349176 > URL: https://svnweb.freebsd.org/changeset/base/349176 >=20 > Log: > random(4): Fix a regression in short AES mode reads > =20 > In r349154, random device reads of size < 16 bytes (AES block size) were > accidentally broken to loop forever. Correct the loop condition for sm= all > reads. > =20 > Reported by: pho > Reviewed by: delphij > Approved by: secteam(delphij) > Differential Revision: https://reviews.freebsd.org/D20686 Hey Conrad, Thanks for fixing this issue! Any plans to MFC? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --mmc352mzirnzscxj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl0JM4oACgkQ/y5nonf4 4foYMhAAkBvajHiOxC2n8HSFApdoK8yiCD9oqpZAQ/PCbjHjWyQger+CSBw5TCJw iahno5TkEo1iakhueB6AIPlWrc8Heq+uwJ9Crdc3x1tWGpvPca30Hbmr3p9Hf9wV /LHGD5VABAOiKg85MgpkwI+sDnNBc330uedqPhvfQ3bMK5v79MF42vKRSVF9kZWR /iGkaUupqyhMVTNBilhL+J39gaUTg6A1Sh5MFDLCAXVZ262n0IFaE55ijxCxPZhD sqw6i8z/b75x9w1P+sQM37jlkp99RFVAsDgAS73C5KF3c40QBlhyxekHz44B+Kd+ E6PigLUDazEYk/CyPrtGJ7G3VrfbEKxUcYm5R524wSDogwctjEaAhfSSo322OREc /7Nzma4/ZYnISNNVch387ynHjWXxWk33lSx6Mg/j+8dkkLsgfhKdoGqCR0Gt3Pe5 AT8GMQNqC+T+DkbVU2+ssHLKf8ARdTA3F9ucFCp1qJN2rxyeFIx4khPik5rGfgi7 QnhIHwQw7LHXrNLFcAAiFc1HWi4O7lDa+0pwz4CXzoXxhs2Z8xaaPqPf9vAa9VDx p88dRHe0X0TM20baL8aviNOh+5yZK+X96AEpUHbcms6zeJvE1x4CgnhHQkb1y7xC msMkTgrrJ+z//rjWWDcLdf+rzpiKmLF+0YTyGz/c6kfMPob+Ihw= =SGyn -----END PGP SIGNATURE----- --mmc352mzirnzscxj--