From owner-cvs-src@FreeBSD.ORG Sat Feb 10 11:36:00 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A249316A401; Sat, 10 Feb 2007 11:36:00 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id EC56A13C442; Sat, 10 Feb 2007 11:35:59 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 69218487FC; Sat, 10 Feb 2007 12:35:57 +0100 (CET) Received: from localhost (cvl74.internetdsl.tpnet.pl [83.19.93.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 210DA487F4; Sat, 10 Feb 2007 12:35:49 +0100 (CET) Date: Sat, 10 Feb 2007 12:34:51 +0100 From: Pawel Jakub Dawidek To: John-Mark Gurney Message-ID: <20070210113451.GA15326@garage.freebsd.pl> References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <20070209211517.GI1620@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <20070209211517.GI1620@funkthat.com> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=BAYES_00, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_XBL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, Brooks Davis , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2007 11:36:00 -0000 --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 09, 2007 at 01:15:17PM -0800, John-Mark Gurney wrote: > Brooks Davis wrote this message on Fri, Feb 09, 2007 at 19:03 +0000: > > brooks 2007-02-09 19:03:18 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/amd64/conf GENERIC=20 > > sys/i386/conf GENERIC=20 > > sys/ia64/conf GENERIC=20 > > sys/pc98/conf GENERIC=20 > > sys/powerpc/conf GENERIC=20 > > sys/sparc64/conf GENERIC=20 > > sys/sun4v/conf GENERIC=20 > > Log: > > Include GEOM_LABEL in GENERIC. It's very useful and not well publici= zed > > enough. > > =20 > > Approved by: pjd >=20 > Can anyone think of a good place to put a warning about using labels > along w/ gmirror? I've had a case recently where I was loading g_label, > but forgot to load g_mirror... Since I was using ufs labels, my fs > mounted perfectly fine, but was mounting only one part of the g_mirror.. > I finally found this out when g_label decided to randomly use the other > disk one boot... >=20 > Maybe g_label should not expose duplicate labels? It only expose one of them - the one which comes first... I'd prefer not to destroy existing provider when duplicated entry appears. Imagine a situation where you have perfectly running system with root mounted from /dev/ufs/root and at some point you insert USB Pendrive with a UFS file system, which also has "root" label. Do you really want the ufs/root provider from under your root file system to be destroyed? Not loading gmirror was configuration mistake. I do want to protect users against such mistakes, but in this situation I think the mistake I described is more common or can be more problematic. If you set kern.geom.label.debug to >=3D 1, glabel will print a warning: Label root(ufs/root) already exists (/dev/ad0s1a). (or something like that). We may consider printing it at the default debug level (0) and see if there are not too many reports from the users with false-positives. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFza3bForvXbEpPzQRAsQ9AKC3Xq4J630JUIXBzsG054Sp7yg4NgCgn/gD dzmIWN6K3NaX9HqB2Bw1VJY= =hgBp -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--