From owner-cvs-src@FreeBSD.ORG  Fri Aug  4 07:44:13 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 227A916A4DD;
	Fri,  4 Aug 2006 07:44:13 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep14-int.chello.at (viefep13-int.chello.at [213.46.255.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9DC3443D46;
	Fri,  4 Aug 2006 07:44:11 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep14-int.chello.at
	(InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id
	<20060804074409.FBKK2199.viefep14-int.chello.at@wombat.fafoe.narf.at>;
	Fri, 4 Aug 2006 09:44:09 +0200
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 46C98BC7E; Fri,  4 Aug 2006 09:23:24 +0200 (CEST)
Date: Fri, 4 Aug 2006 09:23:23 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Yar Tikhiy <yar@comp.chem.msu.su>
Message-ID: <20060804072323.GC89735@wombat.fafoe.narf.at>
References: <200608031905.k73J55D2061870@repoman.freebsd.org>
	<44D29FB6.9090209@freebsd.org>
	<20060804012514.GA63379@what-creek.com>
	<20060804071909.GS97316@comp.chem.msu.su>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060804071909.GS97316@comp.chem.msu.su>
User-Agent: Mutt/1.5.12-2006-07-14
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, pdeuskar@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2006 07:44:13 -0000

On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote:
> 
> As a general remark, it is a very good idea to keep large style(9)
> sweeps separate from actual code changes even if they are tiny.
> Changing style(9) shouldn't alter the binary code produced, and
> this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1).
> Of course, changing line numbers will affect debug info, but the
> latter can be strip(1)'ed.  In the case under discussion, I'd compare
> if_em.o with its former version to make sure no code changed.

It will produce different code if __LINE__ is used.

Stefan