From owner-freebsd-current@freebsd.org Wed Dec 14 22:04:36 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74237C803F5 for ; Wed, 14 Dec 2016 22:04:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt0-x233.google.com (mail-qt0-x233.google.com [IPv6:2607:f8b0:400d:c0d::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2DF90D1B; Wed, 14 Dec 2016 22:04:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt0-x233.google.com with SMTP id n6so39291478qtd.1; Wed, 14 Dec 2016 14:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NwF1N6pBXLTD2lB0HeTBuByf0LAfBjDCiWMhCtoodZk=; b=hrJzQxmk51jbuM76FF6Suhn5meFHiT88ew5llrUUncnbVL7GacXFnbRIyhZ/flqzov bCjO9aPt1m4ZYP4S7p2DiCE9ywF2oCpxhK2HzM6tDzbY2jjyjDT7aOHSK2zNuvovtUY2 OnM/H49ShDiwVHc169Q3pPb2ceYb8B5v9r7+esmAg2QO13/A1KGyUVQ8kR+woHLawcaD rSVfpQdVxpZHQZ1jxo56j51lvXrZmDT8Ch8XEFlY3efevtY3nvQjXB+Y7kuffhSGSQcI 34eS1ZgzrIaD6ZB74O4WXcO4MMHPUSdl3MIelPzGD+vuc3b4G90bi/7yfC/FKA5JX7Z8 z60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=NwF1N6pBXLTD2lB0HeTBuByf0LAfBjDCiWMhCtoodZk=; b=F1oziCE7V5q5WRYti6nUPYvsKIJ3MHQoAfNaDAl07rAFNUEmFKgMGIui3vZ9srMgOl 4rjjy/rvxWvgLfqguRym2XrAuMT2ftq+sm5HEsx/GdtXCX+jIYnPHcIhLQ6F7srZoZt/ 8WuofQL1vF0ddx65UqztuldF9uI4iVR4IhcCcdOCV7nuFTwZbkENoau3Th5A1lQkPKjd cllttUwS0GiQhtiFp/CJpnW0s3zSgOrTn4E9pgXxtEfyOnpdRYkUSufngFvnlTXTJyA+ +L3J/59EkjINDr3hV5vSD+5hs1AKoU9wafMVGb13npei6j2e3VVDQuOUyIFarrTIeuuG Gubg== X-Gm-Message-State: AKaTC010k8ukkTbhhmhaiyWkv3t7xylrlVWq0MWq+UWZsE//d7GOVTeC9XWG1Yf+WWPX3w== X-Received: by 10.200.38.39 with SMTP id u36mr98863381qtu.31.1481753075350; Wed, 14 Dec 2016 14:04:35 -0800 (PST) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id s65sm32810470qtd.2.2016.12.14.14.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2016 14:04:34 -0800 (PST) Sender: Mark Johnston Date: Wed, 14 Dec 2016 14:10:48 -0800 From: Mark Johnston To: kargl@uw.edu Cc: freebsd-current@freebsd.org, kib@freebsd.org Subject: Re: Revision 309657 to stack_machdep.c renders unbootable system Message-ID: <20161214221048.GB64767@wkstn-mjohnston.west.isilon.com> References: <20161214194848.GA881@troutmask.apl.washington.edu> <20161214201416.GA64767@wkstn-mjohnston.west.isilon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214201416.GA64767@wkstn-mjohnston.west.isilon.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 22:04:36 -0000 On Wed, Dec 14, 2016 at 12:14:16PM -0800, Mark Johnston wrote: > On Wed, Dec 14, 2016 at 11:49:26AM -0800, Steven G. Kargl wrote: > > Well, after 3 days of bisection, I finally found the commit > > that renders my system unbootable. The system does not panic. > > It simply gets stuck in some state. Nonfunctional keyboard, > > so can't break into debugger. No serial console available. > > The verbose dmesg.boot for a working kernel from revision > > 309656 is at > > > > http://troutmask.apl.washington.edu/~kargl/freebsd/dmesg.309656.txt > > > > The kernel config file is at > > > > http://troutmask.apl.washington.edu/~kargl/freebsd/SPEW.txt > > > > In looking at /usr/src/UPDATING, there is no warning that one > > can create a boat anchor by upgrading to 309657. If compiling > > a kernel with 'options DDB' is no longer supported, this should > > be stated in UPDATING. Or, UPDATING should state that 'options > > DDB' requires 'options STACK'. Or, 'options DDB' should simply > > to the right thing and pull in whatever 'option STACK' does. > > It is supported though - the point of that change was to fix a problem > that occurred when DDB is configured but STACK isn't. While testing I > tried every combination of the two options, and I just tried and > successfully booted a kernel with DDB and !STACK. > > Does the kernel boot successfully if STACK is added to your > configuration? I tried your config (plus virtio drivers) and was able to reproduce the hang in bhyve. Adding STACK "fixed" the hang, as did reverting part of my change to re-add dead code into the kernel. My VM was always hanging after printing 000.000050 [ 426] vtnet_netmap_attach virtio attached txq=1, txd=1024 rxq=1, rxd=1024 Sure enough, removing "device netmap" from your config also fixes the hang. When the hang occurs, I can see with "bhyvectl --get-rip" that we're stuck in DELAY(), but I can't get a stack at that point. I think my change is an innocent bystander - it just happened to expose a latent issue elsewhere. I don't have much more time to look at this right now, but I'll look into it more tonight.